feat(skills): implement 1.13c Shout [Skill #138] (fixes #292)

src/game/skills/impl/bar/skill-138-shout.ts

@@ -0,0 +1,44 @@
+/**
+ * Diablo II: Lord of Destruction v1.13c — Skill #138: Shout (BAR)
+ *
+ * Authoritative 1.13c Ground Truth (`Patch_D2.mpq` -> `data\\global\\excel\\Skills.txt`):
+ * - Skill ID: 138 ("Shout")
+ * - Class: "bar"
+ * - Required Level: 6
+ * - Server Functions: srvstfunc=0, srvdofunc=68, srvprgfunc1=0, srvprgfunc2=0, srvprgfunc3=0
+ * - Associated Missile / State / Summon: missile="shout", state="shout", summon=""
+ * - 1.13c Synergy Formulas: EDmgSymPerCalc="", DmgSymPerCalc="", ELenSymPerCalc=""
+ */
+import type {
+  SkillEvalContext,
+  SkillEvalResult,
+  SkillExecContext,
+  SkillExecOutcome,
+  SkillModule,
+} from '../../types.ts'
+import { evaluateSkillCore113c, executeSkillCore113c } from '../../registry.ts'
+
+export const skillModule: SkillModule = {
+  skillId: 138,
+  name: "Shout",
+  charClass: "bar",
+  srvStFunc: 0,
+  srvDoFunc: 68,
+
+  evaluate(ctx: SkillEvalContext): SkillEvalResult {
+    return evaluateSkillCore113c(ctx)
+  },
+
+  executeDo(ctx: SkillExecContext): SkillExecOutcome {
+    const outcome = executeSkillCore113c(ctx)
+    return {
+      ...outcome,
+      notes: [
+        ...outcome.notes,
+        'skill_module:skill-138-shout',
+      ],
+    }
+  },
+}
+
+export default skillModule

tests/skills/bar/skill-138-shout.test.ts

@@ -0,0 +1,109 @@
+/**
+ * 1.13c Numerical & Runtime Verification Suite — Skill #138: Shout (BAR)
+ * Gitea Tracking Issue: #292
+ */
+import { describe, expect, it } from 'vitest'
+import { getSharedDataRegistry } from '../../../src/game/engine/data-registry.ts'
+import { UnitStatList } from '../../../src/game/engine/stat-list.ts'
+import { WorldArena } from '../../../src/game/engine/world-arena.ts'
+import { skillModule } from '../../../src/game/skills/impl/bar/skill-138-shout.ts'
+
+describe('[Skill #138] Shout (BAR) — 1.13c Parity (Issue #292)', () => {
+  it('evaluates exact 1.13c Skills.txt / Missiles.txt formulas at slvl 1, 10, and 20', async () => {
+    const registry = await getSharedDataRegistry()
+    const skillRec = registry.getSkillById(138)!
+    expect(skillRec).toBeDefined()
+    expect(skillModule.skillId).toBe(138)
+    expect(skillModule.name).toBe("Shout")
+    expect(skillModule.charClass).toBe("bar")
+
+    const stats1 = new UnitStatList()
+    stats1.setBaseSkillLevel(138, 1)
+    const r1 = skillModule.evaluate!({ registry, skill: skillRec, slvl: 1, blvl: 1, statList: stats1 })
+    expect(r1.manaCost).toBe(6)
+    expect(r1.manaCost256).toBe(1536)
+    expect(r1.minPhysDmg).toBe(0)
+    expect(r1.maxPhysDmg).toBe(0)
+    expect(r1.minElemDmg256).toBe(0)
+    expect(r1.maxElemDmg256).toBe(0)
+
+    const stats10 = new UnitStatList()
+    stats10.setBaseSkillLevel(138, 10)
+    const r10 = skillModule.evaluate!({ registry, skill: skillRec, slvl: 10, blvl: 10, statList: stats10 })
+    expect(r10.manaCost).toBe(6)
+    expect(r10.manaCost256).toBe(1536)
+    expect(r10.minPhysDmg).toBe(0)
+    expect(r10.maxPhysDmg).toBe(0)
+    expect(r10.minElemDmg256).toBe(0)
+    expect(r10.maxElemDmg256).toBe(0)
+
+    const stats20 = new UnitStatList()
+    stats20.setBaseSkillLevel(138, 20)
+    const r20 = skillModule.evaluate!({ registry, skill: skillRec, slvl: 20, blvl: 20, statList: stats20 })
+    expect(r20.manaCost).toBe(6)
+    expect(r20.manaCost256).toBe(1536)
+    expect(r20.minPhysDmg).toBe(0)
+    expect(r20.maxPhysDmg).toBe(0)
+    expect(r20.minElemDmg256).toBe(0)
+    expect(r20.maxElemDmg256).toBe(0)
+    expect(r20.durationFrames).toBe(5250)
+    expect(r20.radiusSubtiles).toBe(290)
+    expect(r20.petMax).toBe(0)
+    expect(r20.cooldownFrames).toBe(0)
+  })
+
+  it('enforces 1.13c blvl synergy rule (hard points boost synergy; +skills and item charges do NOT)', async () => {
+    const registry = await getSharedDataRegistry()
+    const skillRec = registry.getSkillById(138)!
+    const synId = null
+
+    const statsBase = new UnitStatList()
+    statsBase.setBaseSkillLevel(138, 20)
+    if (synId !== null) {
+      statsBase.setBaseSkillLevel(synId, 20)
+    }
+    const withHardPoints = skillModule.evaluate!({
+      registry,
+      skill: skillRec,
+      slvl: 20,
+      blvl: 20,
+      statList: statsBase,
+    })
+    expect(withHardPoints.synergyBonusPct).toBe(0)
+
+    // +20 allskills and +33 Marrowwalk charges without hard points must yield 0 synergy
+    const statsSoftOnly = new UnitStatList()
+    statsSoftOnly.setBaseSkillLevel(138, 20)
+    statsSoftOnly.addStat('item_allskills', 20)
+    if (synId !== null) {
+      statsSoftOnly.setChargedSkillLevel(synId, 33)
+    }
+    const withSoftOnly = skillModule.evaluate!({
+      registry,
+      skill: skillRec,
+      slvl: 20,
+      blvl: 20,
+      statList: statsSoftOnly,
+    })
+    expect(withSoftOnly.synergyBonusPct).toBe(0)
+  })
+
+  it('executes runtime skill effect in WorldArena (castCount, action frame, and combat/state/missile/summon outcome)', async () => {
+    const registry = await getSharedDataRegistry()
+    const arena = new WorldArena({
+      registry,
+      classCode: "bar",
+      skillId: 138,
+      slvl: 20,
+    })
+    const outcome = arena.triggerCast()
+    arena.stepTicks(15)
+    const dbg = arena.getDebugState()
+
+    expect(dbg.ready).toBe(true)
+    expect(dbg.skillId).toBe(138)
+    expect(dbg.castCount).toBeGreaterThanOrEqual(1)
+    expect(dbg.actionFrameTriggered).toBe(true)
+    expect(outcome?.executed).toBe(true)
+  })
+})