troytt
/
diablo2-web
1
0
Fork 0
Code Issues 12 Pull Requests Packages Projects Releases Wiki Activity

[Skill #058] [SOR] Energy Shield (1.13c Parity) #212

New Issue
Closed
opened 2026-09-22 02:40:07 +00:00 by troytt · 2 comments
troytt commented 2026-09-22 02:40:07 +00:00
Owner
Copy Link

Diablo II: Lord of Destruction v1.13c Skill Parity Specification

Field Value
Skill ID 58 (#058)
Skill Name Energy Shield (skilldesc: energy shield)
Class sor (Sorceress)
Required Level (reqlevel) 24
Prerequisites (reqskill1..3) Teleport, Chain Lightning, -
Isolated Implementation Module src/game/skills/impl/sor/skill-058-energy-shield.ts
Isolated Vitest Suite tests/skills/sor/skill-058-energy-shield.test.ts

1. Authoritative 1.13c Skills.txt Function & Handler Dispatch

Function Slot 1.13c Value
srvstfunc (Server Start / Pre-Cast) -
srvdofunc (Server Action Frame 0x01/0x02) 23
srvprgfunc1..3 (Progressive Charge Release) - / - / -
cltstfunc / cltdofunc (Client Start / Action) - / -
cltprgfunc1..3 (Client Progressive Release) - / - / -
passive / checkfunc passive=- / checkfunc=-
auraevent1 / auraeventfunc1 absorbdamage / 24

2. Associated Missiles, States, Auras, Curses & Summons

Subsystem 1.13c Configuration
Server Missiles (srvmissile / a..c) - / a:-, b:-, c:-
Client Missiles (cltmissile / cltmissilea) - / -
Aura / Buff States (aurastate / auratgtstate) self:energyshield / tgt:-
Aura / Buff Stats (aurastat1..3) -, -, -
Passive State & Stats (passivestate / passivestat1..3) state:- / -, -, -
Curse Priority (cursetype) -
Summon / Pet (summon / pettype / petmax) mon:- / type:- / max:-

3. 1.13c Base Numerical & Synergy Formulas (Patch_D2.mpq)

  • Mana Cost: mana=5, lvlmana=0 (256-fixed-point << HitShift)
  • Physical / Elemental Damage: MinDam=-, MaxDam=-, EType=-, EMin=20, EMax=-, ELen=-
  • AST calc1..4: calc1="min(edmn,95)", calc2=par5-skill('Telekinesis'.blvl), calc3=-, calc4=-
  • Synergy Calculations (blvl strictly base allocated STAT_SKILLPTS only):
    • EDmgSymPerCalc: -
    • DmgSymPerCalc: -
    • ELenSymPerCalc: -

4. R3 Verification & Merge Checklist

  • Isolated Git Worktree: Created via git worktree add ../wt-skill-58 -b feat/skill-58 from main.
  • 1.13c Implementation: src/game/skills/impl/sor/skill-058-energy-shield.ts implements exact 1.13c srvstfunc/srvdofunc/srvprgfunc & numerical evaluation.
  • Automated Unit & Numerical Tests (slvl 1, 10, 20 + blvl Synergies): tests/skills/sor/skill-058-energy-shield.test.ts passes 100% in Vitest verifying ManaCost, MinDmg, MaxDmg, ToHit, Duration, Radius, synergy scaling, and runtime combat/missile/state/summon effect.
  • Real-Browser Casting & Screenshot: Executed in headless Chromium (acts.html?arena=1&class=sor&skill=58&slvl=20&autocast=1) with zero console/page errors and PNG screenshot attached to this Issue.
  • Merge & Cleanup: Merged to main with fixes #<issue_number>, pushed to origin/main, verified Issue is closed, and removed worktree ../wt-skill-58 + branch feat/skill-58.
## Diablo II: Lord of Destruction v1.13c Skill Parity Specification | Field | Value | |---|---| | **Skill ID** | `58` (`#058`) | | **Skill Name** | **Energy Shield** (`skilldesc: energy shield`) | | **Class** | `sor` (Sorceress) | | **Required Level (`reqlevel`)** | `24` | | **Prerequisites (`reqskill1..3`)** | `Teleport`, `Chain Lightning`, `-` | | **Isolated Implementation Module** | `src/game/skills/impl/sor/skill-058-energy-shield.ts` | | **Isolated Vitest Suite** | `tests/skills/sor/skill-058-energy-shield.test.ts` | --- ### 1. Authoritative 1.13c `Skills.txt` Function & Handler Dispatch | Function Slot | 1.13c Value | |---|---| | **`srvstfunc`** (Server Start / Pre-Cast) | `-` | | **`srvdofunc`** (Server Action Frame `0x01`/`0x02`) | `23` | | **`srvprgfunc1..3`** (Progressive Charge Release) | `-` / `-` / `-` | | **`cltstfunc` / `cltdofunc`** (Client Start / Action) | `-` / `-` | | **`cltprgfunc1..3`** (Client Progressive Release) | `-` / `-` / `-` | | **`passive` / `checkfunc`** | `passive=-` / `checkfunc=-` | | **`auraevent1` / `auraeventfunc1`** | `absorbdamage` / `24` | ### 2. Associated Missiles, States, Auras, Curses & Summons | Subsystem | 1.13c Configuration | |---|---| | **Server Missiles (`srvmissile` / `a..c`)** | `-` / `a:-`, `b:-`, `c:-` | | **Client Missiles (`cltmissile` / `cltmissilea`)** | `-` / `-` | | **Aura / Buff States (`aurastate` / `auratgtstate`)** | `self:energyshield` / `tgt:-` | | **Aura / Buff Stats (`aurastat1..3`)** | `-`, `-`, `-` | | **Passive State & Stats (`passivestate` / `passivestat1..3`)** | `state:-` / `-`, `-`, `-` | | **Curse Priority (`cursetype`)** | `-` | | **Summon / Pet (`summon` / `pettype` / `petmax`)** | `mon:-` / `type:-` / `max:-` | ### 3. 1.13c Base Numerical & Synergy Formulas (`Patch_D2.mpq`) - **Mana Cost**: `mana=5`, `lvlmana=0` (256-fixed-point `<< HitShift`) - **Physical / Elemental Damage**: `MinDam=-`, `MaxDam=-`, `EType=-`, `EMin=20`, `EMax=-`, `ELen=-` - **AST `calc1..4`**: `calc1="min(edmn,95)"`, `calc2=par5-skill('Telekinesis'.blvl)`, `calc3=-`, `calc4=-` - **Synergy Calculations (`blvl` strictly base allocated `STAT_SKILLPTS` only)**: - `EDmgSymPerCalc`: `-` - `DmgSymPerCalc`: `-` - `ELenSymPerCalc`: `-` --- ### 4. R3 Verification & Merge Checklist - [ ] **Isolated Git Worktree**: Created via `git worktree add ../wt-skill-58 -b feat/skill-58` from `main`. - [ ] **1.13c Implementation**: `src/game/skills/impl/sor/skill-058-energy-shield.ts` implements exact 1.13c `srvstfunc`/`srvdofunc`/`srvprgfunc` & numerical evaluation. - [ ] **Automated Unit & Numerical Tests (`slvl` 1, 10, 20 + `blvl` Synergies)**: `tests/skills/sor/skill-058-energy-shield.test.ts` passes 100% in Vitest verifying `ManaCost`, `MinDmg`, `MaxDmg`, `ToHit`, `Duration`, `Radius`, synergy scaling, and runtime combat/missile/state/summon effect. - [ ] **Real-Browser Casting & Screenshot**: Executed in headless Chromium (`acts.html?arena=1&class=sor&skill=58&slvl=20&autocast=1`) with zero console/page errors and PNG screenshot attached to this Issue. - [ ] **Merge & Cleanup**: Merged to `main` with `fixes #<issue_number>`, pushed to `origin/main`, verified Issue is `closed`, and removed worktree `../wt-skill-58` + branch `feat/skill-58`.
skill-058-energy-shield.png
574 KiB
skill-058-energy-shield.png
troytt added this to the All Player Skills (v1.13c Parity) milestone 2026-09-22 02:40:07 +00:00
troytt commented 2026-09-22 03:49:34 +00:00
Author
Owner
Copy Link

✅ Completed: [Skill #058] Energy Shield (SOR) — 1.13c Parity Verified

1. Isolated Worktree & Module Implementation

  • Worktree & Branch: ../wt-skill-058 (feat/skill-058)
  • Skill Module: src/game/skills/impl/sor/skill-058-energy-shield.ts
  • Vitest Suite: tests/skills/sor/skill-058-energy-shield.test.ts
  • 1.13c Dispatch: srvstfunc=0, srvdofunc=23, missile=none, state=energyshield, summon=none

2. 1.13c Numerical & Synergy Verification Table

Metric slvl = 1 slvl = 10 slvl = 20 (0 Syn) slvl = 20 (+20 blvl Syn)
Mana Cost (usmc) 5 (1280) 5 (1280) 5 (1280) 5 (1280)
Phys Dmg (Min-Max) 0-0 0-0 0-0 0-0
Elem Dmg (Min-Max) 20-0 (mag) 59-0 (mag) 75-0 (mag) 75-0 (+0%)
AR % / Duration / Radius +0% / 3600f / 3600 +0% / 17100f / 17100 +0% / 32100f / 32100 +0% / 32100f / 32100

3. Headless Chromium (chromium-1228) Runtime Telemetry & Screenshot

  • Arena State: ready=true, classCode=sor (so), castCount=1, anim=SC:7, totalDamageDealt=0, consoleErrors=0
  • Captured PNG Size: 588213 bytes

Skill #058 Energy Shield

### ✅ Completed: [Skill #058] Energy Shield (`SOR`) — 1.13c Parity Verified #### 1. Isolated Worktree & Module Implementation - **Worktree & Branch**: `../wt-skill-058` (`feat/skill-058`) - **Skill Module**: `src/game/skills/impl/sor/skill-058-energy-shield.ts` - **Vitest Suite**: `tests/skills/sor/skill-058-energy-shield.test.ts` - **1.13c Dispatch**: `srvstfunc=0`, `srvdofunc=23`, `missile=none`, `state=energyshield`, `summon=none` #### 2. 1.13c Numerical & Synergy Verification Table | Metric | `slvl = 1` | `slvl = 10` | `slvl = 20` (0 Syn) | `slvl = 20` (+20 `blvl` Syn) | | :--- | :---: | :---: | :---: | :---: | | **Mana Cost (`usmc`)** | `5` (`1280`) | `5` (`1280`) | `5` (`1280`) | `5` (`1280`) | | **Phys Dmg (`Min-Max`)** | `0-0` | `0-0` | `0-0` | `0-0` | | **Elem Dmg (`Min-Max`)** | `20-0` (`mag`) | `59-0` (`mag`) | `75-0` (`mag`) | `75-0` (+0%) | | **AR % / Duration / Radius** | `+0%` / `3600f` / `3600` | `+0%` / `17100f` / `17100` | `+0%` / `32100f` / `32100` | `+0%` / `32100f` / `32100` | #### 3. Headless Chromium (`chromium-1228`) Runtime Telemetry & Screenshot - **Arena State**: `ready=true`, `classCode=sor` (`so`), `castCount=1`, `anim=SC:7`, `totalDamageDealt=0`, `consoleErrors=0` - **Captured PNG Size**: `588213` bytes ![Skill #058 Energy Shield](https://git.projectdiablo2.cn/attachments/7c93630e-cc33-472c-8c24-f978a4bc0276)
troytt commented 2026-09-23 20:35:07 +00:00
Author
Owner
Copy Link

Milestone M4 Complete: Energy Shield (58) 1.13c Ground-Truth Parity Verified

  • Commit: a0567c2 (merged to main)
  • Test Suite: tests/skills/sor/skill-058-energy-shield.test.ts (15/15 tests passing)
  • 7-Dimensional Parity Details:
    • D1: Skills.txt row 58 parsing (mana 5, manashift 8, castoverlay light_cast_2, aurastate energyshield, Param5=32).
    • D2: Overlays energyshield (ManaShieldBall) looping body overlay, energyshieldhit0 hit overlay, light_cast_2 cast overlay.
    • D3: Piecewise absorption: 20% lvl 1, +5% lvl 2-8, +2% lvl 9-16, +1% lvl 17+, strictly hard capped at 95% (lvl 40).
    • D4: Telekinesis hard synergy ratio: (32 - Math.min(20, Math.max(0, tkBlvl))) / 16 (2.0 down to 0.75). Hard points only (blvl); soft points ignored.
    • D5: Absorbs raw damage BEFORE player resistances are applied; unabsorbed damage mitigated by player resistances. Poison (elemType === "pois" || isPoison) and Open Wounds strictly bypass ES directly to HP with 0 mana drained.
    • D6: Mana depletion drains mana to 0, collapses shield (removeState("energyshield"), removeState(60)), and remainder spills directly to HP.
    • D7: BATCH1_SKILLS length invariant strictly 38, zero runtime MPQ queries.
### Milestone M4 Complete: Energy Shield (58) 1.13c Ground-Truth Parity Verified - **Commit**: `a0567c2` (merged to `main`) - **Test Suite**: `tests/skills/sor/skill-058-energy-shield.test.ts` (15/15 tests passing) - **7-Dimensional Parity Details**: - D1: Skills.txt row 58 parsing (mana 5, manashift 8, castoverlay light_cast_2, aurastate energyshield, Param5=32). - D2: Overlays `energyshield` (ManaShieldBall) looping body overlay, `energyshieldhit0` hit overlay, `light_cast_2` cast overlay. - D3: Piecewise absorption: 20% lvl 1, +5% lvl 2-8, +2% lvl 9-16, +1% lvl 17+, strictly hard capped at 95% (lvl 40). - D4: Telekinesis hard synergy ratio: `(32 - Math.min(20, Math.max(0, tkBlvl))) / 16` (2.0 down to 0.75). Hard points only (`blvl`); soft points ignored. - D5: Absorbs raw damage BEFORE player resistances are applied; unabsorbed damage mitigated by player resistances. Poison (`elemType === "pois" || isPoison`) and Open Wounds strictly bypass ES directly to HP with 0 mana drained. - D6: Mana depletion drains mana to 0, collapses shield (`removeState("energyshield")`, `removeState(60)`), and remainder spills directly to HP. - D7: `BATCH1_SKILLS` length invariant strictly 38, zero runtime MPQ queries.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
All Player Skills (v1.13c Parity)
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: troytt/diablo2-web#212
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?