troytt
/
diablo2-web
1
0
Fork 0
Code Issues 12 Pull Requests Packages Projects Releases Wiki Activity

[Skill #061] [SOR] Fire Mastery (1.13c Parity) #215

New Issue
Closed
opened 2026-09-22 02:40:07 +00:00 by troytt · 2 comments
troytt commented 2026-09-22 02:40:07 +00:00
Owner
Copy Link

Diablo II: Lord of Destruction v1.13c Skill Parity Specification

Field Value
Skill ID 61 (#061)
Skill Name Fire Mastery (skilldesc: fire mastery)
Class sor (Sorceress)
Required Level (reqlevel) 30
Prerequisites (reqskill1..3) -, -, -
Isolated Implementation Module src/game/skills/impl/sor/skill-061-fire-mastery.ts
Isolated Vitest Suite tests/skills/sor/skill-061-fire-mastery.test.ts

1. Authoritative 1.13c Skills.txt Function & Handler Dispatch

Function Slot 1.13c Value
srvstfunc (Server Start / Pre-Cast) -
srvdofunc (Server Action Frame 0x01/0x02) -
srvprgfunc1..3 (Progressive Charge Release) - / - / -
cltstfunc / cltdofunc (Client Start / Action) - / -
cltprgfunc1..3 (Client Progressive Release) - / - / -
passive / checkfunc passive=1 / checkfunc=-
auraevent1 / auraeventfunc1 - / -

2. Associated Missiles, States, Auras, Curses & Summons

Subsystem 1.13c Configuration
Server Missiles (srvmissile / a..c) - / a:-, b:-, c:-
Client Missiles (cltmissile / cltmissilea) - / -
Aura / Buff States (aurastate / auratgtstate) self:- / tgt:-
Aura / Buff Stats (aurastat1..3) -, -, -
Passive State & Stats (passivestate / passivestat1..3) state:firemastery / passive_fire_mastery, -, -
Curse Priority (cursetype) -
Summon / Pet (summon / pettype / petmax) mon:- / type:- / max:-

3. 1.13c Base Numerical & Synergy Formulas (Patch_D2.mpq)

  • Mana Cost: mana=0, lvlmana=0 (256-fixed-point << HitShift)
  • Physical / Elemental Damage: MinDam=-, MaxDam=-, EType=fire, EMin=-, EMax=-, ELen=-
  • AST calc1..4: calc1=-, calc2=-, calc3=-, calc4=-
  • Synergy Calculations (blvl strictly base allocated STAT_SKILLPTS only):
    • EDmgSymPerCalc: -
    • DmgSymPerCalc: -
    • ELenSymPerCalc: -

4. R3 Verification & Merge Checklist

  • Isolated Git Worktree: Created via git worktree add ../wt-skill-61 -b feat/skill-61 from main.
  • 1.13c Implementation: src/game/skills/impl/sor/skill-061-fire-mastery.ts implements exact 1.13c srvstfunc/srvdofunc/srvprgfunc & numerical evaluation.
  • Automated Unit & Numerical Tests (slvl 1, 10, 20 + blvl Synergies): tests/skills/sor/skill-061-fire-mastery.test.ts passes 100% in Vitest verifying ManaCost, MinDmg, MaxDmg, ToHit, Duration, Radius, synergy scaling, and runtime combat/missile/state/summon effect.
  • Real-Browser Casting & Screenshot: Executed in headless Chromium (acts.html?arena=1&class=sor&skill=61&slvl=20&autocast=1) with zero console/page errors and PNG screenshot attached to this Issue.
  • Merge & Cleanup: Merged to main with fixes #<issue_number>, pushed to origin/main, verified Issue is closed, and removed worktree ../wt-skill-61 + branch feat/skill-61.
## Diablo II: Lord of Destruction v1.13c Skill Parity Specification | Field | Value | |---|---| | **Skill ID** | `61` (`#061`) | | **Skill Name** | **Fire Mastery** (`skilldesc: fire mastery`) | | **Class** | `sor` (Sorceress) | | **Required Level (`reqlevel`)** | `30` | | **Prerequisites (`reqskill1..3`)** | `-`, `-`, `-` | | **Isolated Implementation Module** | `src/game/skills/impl/sor/skill-061-fire-mastery.ts` | | **Isolated Vitest Suite** | `tests/skills/sor/skill-061-fire-mastery.test.ts` | --- ### 1. Authoritative 1.13c `Skills.txt` Function & Handler Dispatch | Function Slot | 1.13c Value | |---|---| | **`srvstfunc`** (Server Start / Pre-Cast) | `-` | | **`srvdofunc`** (Server Action Frame `0x01`/`0x02`) | `-` | | **`srvprgfunc1..3`** (Progressive Charge Release) | `-` / `-` / `-` | | **`cltstfunc` / `cltdofunc`** (Client Start / Action) | `-` / `-` | | **`cltprgfunc1..3`** (Client Progressive Release) | `-` / `-` / `-` | | **`passive` / `checkfunc`** | `passive=1` / `checkfunc=-` | | **`auraevent1` / `auraeventfunc1`** | `-` / `-` | ### 2. Associated Missiles, States, Auras, Curses & Summons | Subsystem | 1.13c Configuration | |---|---| | **Server Missiles (`srvmissile` / `a..c`)** | `-` / `a:-`, `b:-`, `c:-` | | **Client Missiles (`cltmissile` / `cltmissilea`)** | `-` / `-` | | **Aura / Buff States (`aurastate` / `auratgtstate`)** | `self:-` / `tgt:-` | | **Aura / Buff Stats (`aurastat1..3`)** | `-`, `-`, `-` | | **Passive State & Stats (`passivestate` / `passivestat1..3`)** | `state:firemastery` / `passive_fire_mastery`, `-`, `-` | | **Curse Priority (`cursetype`)** | `-` | | **Summon / Pet (`summon` / `pettype` / `petmax`)** | `mon:-` / `type:-` / `max:-` | ### 3. 1.13c Base Numerical & Synergy Formulas (`Patch_D2.mpq`) - **Mana Cost**: `mana=0`, `lvlmana=0` (256-fixed-point `<< HitShift`) - **Physical / Elemental Damage**: `MinDam=-`, `MaxDam=-`, `EType=fire`, `EMin=-`, `EMax=-`, `ELen=-` - **AST `calc1..4`**: `calc1=-`, `calc2=-`, `calc3=-`, `calc4=-` - **Synergy Calculations (`blvl` strictly base allocated `STAT_SKILLPTS` only)**: - `EDmgSymPerCalc`: `-` - `DmgSymPerCalc`: `-` - `ELenSymPerCalc`: `-` --- ### 4. R3 Verification & Merge Checklist - [ ] **Isolated Git Worktree**: Created via `git worktree add ../wt-skill-61 -b feat/skill-61` from `main`. - [ ] **1.13c Implementation**: `src/game/skills/impl/sor/skill-061-fire-mastery.ts` implements exact 1.13c `srvstfunc`/`srvdofunc`/`srvprgfunc` & numerical evaluation. - [ ] **Automated Unit & Numerical Tests (`slvl` 1, 10, 20 + `blvl` Synergies)**: `tests/skills/sor/skill-061-fire-mastery.test.ts` passes 100% in Vitest verifying `ManaCost`, `MinDmg`, `MaxDmg`, `ToHit`, `Duration`, `Radius`, synergy scaling, and runtime combat/missile/state/summon effect. - [ ] **Real-Browser Casting & Screenshot**: Executed in headless Chromium (`acts.html?arena=1&class=sor&skill=61&slvl=20&autocast=1`) with zero console/page errors and PNG screenshot attached to this Issue. - [ ] **Merge & Cleanup**: Merged to `main` with `fixes #<issue_number>`, pushed to `origin/main`, verified Issue is `closed`, and removed worktree `../wt-skill-61` + branch `feat/skill-61`.
skill-061-fire-mastery.png
573 KiB
skill-061-fire-mastery.png
troytt added this to the All Player Skills (v1.13c Parity) milestone 2026-09-22 02:40:07 +00:00
troytt commented 2026-09-22 03:49:40 +00:00
Author
Owner
Copy Link

✅ Completed: [Skill #061] Fire Mastery (SOR) — 1.13c Parity Verified

1. Isolated Worktree & Module Implementation

  • Worktree & Branch: ../wt-skill-061 (feat/skill-061)
  • Skill Module: src/game/skills/impl/sor/skill-061-fire-mastery.ts
  • Vitest Suite: tests/skills/sor/skill-061-fire-mastery.test.ts
  • 1.13c Dispatch: srvstfunc=0, srvdofunc=0, missile=none, state=firemastery, summon=none

2. 1.13c Numerical & Synergy Verification Table

Metric slvl = 1 slvl = 10 slvl = 20 (0 Syn) slvl = 20 (+20 blvl Syn)
Mana Cost (usmc) 0 (0) 0 (0) 0 (0) 0 (0)
Phys Dmg (Min-Max) 0-0 0-0 0-0 0-0
Elem Dmg (Min-Max) 0-0 (fire) 0-0 (fire) 0-0 (fire) 0-0 (+0%)
AR % / Duration / Radius +0% / 0f / 30 +0% / 0f / 93 +0% / 0f / 163 +0% / 0f / 163

3. Headless Chromium (chromium-1228) Runtime Telemetry & Screenshot

  • Arena State: ready=true, classCode=sor (so), castCount=1, anim=SC:6, totalDamageDealt=0, consoleErrors=0
  • Captured PNG Size: 586470 bytes

Skill #061 Fire Mastery

### ✅ Completed: [Skill #061] Fire Mastery (`SOR`) — 1.13c Parity Verified #### 1. Isolated Worktree & Module Implementation - **Worktree & Branch**: `../wt-skill-061` (`feat/skill-061`) - **Skill Module**: `src/game/skills/impl/sor/skill-061-fire-mastery.ts` - **Vitest Suite**: `tests/skills/sor/skill-061-fire-mastery.test.ts` - **1.13c Dispatch**: `srvstfunc=0`, `srvdofunc=0`, `missile=none`, `state=firemastery`, `summon=none` #### 2. 1.13c Numerical & Synergy Verification Table | Metric | `slvl = 1` | `slvl = 10` | `slvl = 20` (0 Syn) | `slvl = 20` (+20 `blvl` Syn) | | :--- | :---: | :---: | :---: | :---: | | **Mana Cost (`usmc`)** | `0` (`0`) | `0` (`0`) | `0` (`0`) | `0` (`0`) | | **Phys Dmg (`Min-Max`)** | `0-0` | `0-0` | `0-0` | `0-0` | | **Elem Dmg (`Min-Max`)** | `0-0` (`fire`) | `0-0` (`fire`) | `0-0` (`fire`) | `0-0` (+0%) | | **AR % / Duration / Radius** | `+0%` / `0f` / `30` | `+0%` / `0f` / `93` | `+0%` / `0f` / `163` | `+0%` / `0f` / `163` | #### 3. Headless Chromium (`chromium-1228`) Runtime Telemetry & Screenshot - **Arena State**: `ready=true`, `classCode=sor` (`so`), `castCount=1`, `anim=SC:6`, `totalDamageDealt=0`, `consoleErrors=0` - **Captured PNG Size**: `586470` bytes ![Skill #061 Fire Mastery](https://git.projectdiablo2.cn/attachments/9c221aa2-f6aa-4b5c-9fea-3de915348804)
troytt commented 2026-09-24 04:00:41 +00:00
Author
Owner
Copy Link

Milestone M4 — Skill #061: Fire Mastery (SOR) 1.13c Implementation & 7-Dimensional Verification Report

Commit: 2e061b3 (merged to main)
Status: Closed & Verified

7-Dimensional Verification Evidence:

  • D1: 1.13c Data Table Parsing & Schema Integrity:
    • Skills.txt row 61 parsed and validated: Id: 61, skill: Fire Mastery, charclass: sor, reqlevel: 30, passive: 1, passivestat1: passive_fire_mastery, passivecalc1: ln12, Param1: 30, Param2: 7, mana: 0, lvlmana: 0, srvdofunc: 0, srvstfunc: 0.
  • D2: Visual Assets & Passive Metadata Integrity:
    • Verified passive skill metadata: no cast overlay (getSkillCastOverlay(61) === undefined), no missile, no projectile.
    • Verified skillModule: skillId: 61, charClass: sor, srvDoFunc: 0, srvStFunc: 0.
  • D3: Formulas & Scaling:
    • Fire damage bonus formula: 30 + (slvl - 1) * 7% verified across slvls 1 (30%), 2 (37%), 10 (93%), 20 (163%), 30 (233%), 40 (303%).
    • Graceful clamping for non-positive / invalid levels (0%).
  • D4: Fire Damage Amplification & Combat Pipeline:
    • Outbound fire damage scaled by (100 + passive_fire_mastery) / 100.
    • Resistance vs Pierce: Fire Mastery scales outbound fire damage without granting fire resistance pierce.
    • Fire immunity preservation: Targets with fire resist >= 100% strictly remain immune (0 damage).
  • D5: Double-Dip Integration with Enchant:
    • Cast multiplier: Scales Enchant fire damage upon cast.
    • Melee double-dip: Sorceress in melee applies Fire Mastery again upon weapon hit.
    • Ranged bypass: Ranged weapon attacks bypass second Fire Mastery multiplier and take 33% penalty.
  • D6: Accrued Stat Integration & Zero Resource Cost:
    • UnitStatList dynamically accrues passive_fire_mastery when base points > 0 or bonus skill > 0.
    • Soft skill scaling verified (+allskills, +classskills boost effective Fire Mastery level).
    • 0 mana cost and 0 cooldown frames.
  • D7: Invariants & Runtime Execution:
    • BATCH1_SKILLS length invariant strictly maintained at 38.
    • Zero Runtime MPQ invariant preserved.
    • WorldArena passive cast execution verified.
### Milestone M4 — Skill #061: Fire Mastery (SOR) 1.13c Implementation & 7-Dimensional Verification Report **Commit**: `2e061b3` (merged to `main`) **Status**: Closed & Verified #### 7-Dimensional Verification Evidence: - **D1: 1.13c Data Table Parsing & Schema Integrity**: - `Skills.txt` row 61 parsed and validated: `Id: 61`, `skill: Fire Mastery`, `charclass: sor`, `reqlevel: 30`, `passive: 1`, `passivestat1: passive_fire_mastery`, `passivecalc1: ln12`, `Param1: 30`, `Param2: 7`, `mana: 0`, `lvlmana: 0`, `srvdofunc: 0`, `srvstfunc: 0`. - **D2: Visual Assets & Passive Metadata Integrity**: - Verified passive skill metadata: no cast overlay (`getSkillCastOverlay(61) === undefined`), no missile, no projectile. - Verified `skillModule`: `skillId: 61`, `charClass: sor`, `srvDoFunc: 0`, `srvStFunc: 0`. - **D3: Formulas & Scaling**: - Fire damage bonus formula: `30 + (slvl - 1) * 7%` verified across slvls 1 (30%), 2 (37%), 10 (93%), 20 (163%), 30 (233%), 40 (303%). - Graceful clamping for non-positive / invalid levels (0%). - **D4: Fire Damage Amplification & Combat Pipeline**: - Outbound fire damage scaled by `(100 + passive_fire_mastery) / 100`. - Resistance vs Pierce: Fire Mastery scales outbound fire damage without granting fire resistance pierce. - Fire immunity preservation: Targets with fire resist >= 100% strictly remain immune (0 damage). - **D5: Double-Dip Integration with Enchant**: - Cast multiplier: Scales Enchant fire damage upon cast. - Melee double-dip: Sorceress in melee applies Fire Mastery again upon weapon hit. - Ranged bypass: Ranged weapon attacks bypass second Fire Mastery multiplier and take 33% penalty. - **D6: Accrued Stat Integration & Zero Resource Cost**: - `UnitStatList` dynamically accrues `passive_fire_mastery` when base points > 0 or bonus skill > 0. - Soft skill scaling verified (+allskills, +classskills boost effective Fire Mastery level). - 0 mana cost and 0 cooldown frames. - **D7: Invariants & Runtime Execution**: - `BATCH1_SKILLS` length invariant strictly maintained at 38. - Zero Runtime MPQ invariant preserved. - WorldArena passive cast execution verified.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
All Player Skills (v1.13c Parity)
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: troytt/diablo2-web#215
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?