troytt
/
diablo2-web
1
0
Fork 0
Code Issues 12 Pull Requests Packages Projects Releases Wiki Activity

[Skill #146] [BAR] Battle Cry (1.13c Parity) #300

New Issue
Closed
opened 2026-09-22 02:40:19 +00:00 by troytt · 1 comment
troytt commented 2026-09-22 02:40:19 +00:00
Owner
Copy Link

Diablo II: Lord of Destruction v1.13c Skill Parity Specification

Field Value
Skill ID 146 (#146)
Skill Name Battle Cry (skilldesc: battle cry)
Class bar (Barbarian)
Required Level (reqlevel) 18
Prerequisites (reqskill1..3) Taunt, -, -
Isolated Implementation Module src/game/skills/impl/bar/skill-146-battle-cry.ts
Isolated Vitest Suite tests/skills/bar/skill-146-battle-cry.test.ts

1. Authoritative 1.13c Skills.txt Function & Handler Dispatch

Function Slot 1.13c Value
srvstfunc (Server Start / Pre-Cast) -
srvdofunc (Server Action Frame 0x01/0x02) 68
srvprgfunc1..3 (Progressive Charge Release) - / - / -
cltstfunc / cltdofunc (Client Start / Action) - / 25
cltprgfunc1..3 (Client Progressive Release) - / - / -
passive / checkfunc passive=- / checkfunc=-
auraevent1 / auraeventfunc1 - / -

2. Associated Missiles, States, Auras, Curses & Summons

Subsystem 1.13c Configuration
Server Missiles (srvmissile / a..c) - / a:battlecry, b:-, c:-
Client Missiles (cltmissile / cltmissilea) - / battlecry
Aura / Buff States (aurastate / auratgtstate) self:- / tgt:-
Aura / Buff Stats (aurastat1..3) skill_armor_percent, damagepercent, -
Passive State & Stats (passivestate / passivestat1..3) state:- / -, -, -
Curse Priority (cursetype) -
Summon / Pet (summon / pettype / petmax) mon:- / type:- / max:-

3. 1.13c Base Numerical & Synergy Formulas (Patch_D2.mpq)

  • Mana Cost: mana=5, lvlmana=0 (256-fixed-point << HitShift)
  • Physical / Elemental Damage: MinDam=-, MaxDam=-, EType=-, EMin=-, EMax=-, ELen=-
  • AST calc1..4: calc1=-, calc2=-, calc3=-, calc4=-
  • Synergy Calculations (blvl strictly base allocated STAT_SKILLPTS only):
    • EDmgSymPerCalc: -
    • DmgSymPerCalc: -
    • ELenSymPerCalc: -

4. R3 Verification & Merge Checklist

  • Isolated Git Worktree: Created via git worktree add ../wt-skill-146 -b feat/skill-146 from main.
  • 1.13c Implementation: src/game/skills/impl/bar/skill-146-battle-cry.ts implements exact 1.13c srvstfunc/srvdofunc/srvprgfunc & numerical evaluation.
  • Automated Unit & Numerical Tests (slvl 1, 10, 20 + blvl Synergies): tests/skills/bar/skill-146-battle-cry.test.ts passes 100% in Vitest verifying ManaCost, MinDmg, MaxDmg, ToHit, Duration, Radius, synergy scaling, and runtime combat/missile/state/summon effect.
  • Real-Browser Casting & Screenshot: Executed in headless Chromium (acts.html?arena=1&class=bar&skill=146&slvl=20&autocast=1) with zero console/page errors and PNG screenshot attached to this Issue.
  • Merge & Cleanup: Merged to main with fixes #<issue_number>, pushed to origin/main, verified Issue is closed, and removed worktree ../wt-skill-146 + branch feat/skill-146.
## Diablo II: Lord of Destruction v1.13c Skill Parity Specification | Field | Value | |---|---| | **Skill ID** | `146` (`#146`) | | **Skill Name** | **Battle Cry** (`skilldesc: battle cry`) | | **Class** | `bar` (Barbarian) | | **Required Level (`reqlevel`)** | `18` | | **Prerequisites (`reqskill1..3`)** | `Taunt`, `-`, `-` | | **Isolated Implementation Module** | `src/game/skills/impl/bar/skill-146-battle-cry.ts` | | **Isolated Vitest Suite** | `tests/skills/bar/skill-146-battle-cry.test.ts` | --- ### 1. Authoritative 1.13c `Skills.txt` Function & Handler Dispatch | Function Slot | 1.13c Value | |---|---| | **`srvstfunc`** (Server Start / Pre-Cast) | `-` | | **`srvdofunc`** (Server Action Frame `0x01`/`0x02`) | `68` | | **`srvprgfunc1..3`** (Progressive Charge Release) | `-` / `-` / `-` | | **`cltstfunc` / `cltdofunc`** (Client Start / Action) | `-` / `25` | | **`cltprgfunc1..3`** (Client Progressive Release) | `-` / `-` / `-` | | **`passive` / `checkfunc`** | `passive=-` / `checkfunc=-` | | **`auraevent1` / `auraeventfunc1`** | `-` / `-` | ### 2. Associated Missiles, States, Auras, Curses & Summons | Subsystem | 1.13c Configuration | |---|---| | **Server Missiles (`srvmissile` / `a..c`)** | `-` / `a:battlecry`, `b:-`, `c:-` | | **Client Missiles (`cltmissile` / `cltmissilea`)** | `-` / `battlecry` | | **Aura / Buff States (`aurastate` / `auratgtstate`)** | `self:-` / `tgt:-` | | **Aura / Buff Stats (`aurastat1..3`)** | `skill_armor_percent`, `damagepercent`, `-` | | **Passive State & Stats (`passivestate` / `passivestat1..3`)** | `state:-` / `-`, `-`, `-` | | **Curse Priority (`cursetype`)** | `-` | | **Summon / Pet (`summon` / `pettype` / `petmax`)** | `mon:-` / `type:-` / `max:-` | ### 3. 1.13c Base Numerical & Synergy Formulas (`Patch_D2.mpq`) - **Mana Cost**: `mana=5`, `lvlmana=0` (256-fixed-point `<< HitShift`) - **Physical / Elemental Damage**: `MinDam=-`, `MaxDam=-`, `EType=-`, `EMin=-`, `EMax=-`, `ELen=-` - **AST `calc1..4`**: `calc1=-`, `calc2=-`, `calc3=-`, `calc4=-` - **Synergy Calculations (`blvl` strictly base allocated `STAT_SKILLPTS` only)**: - `EDmgSymPerCalc`: `-` - `DmgSymPerCalc`: `-` - `ELenSymPerCalc`: `-` --- ### 4. R3 Verification & Merge Checklist - [ ] **Isolated Git Worktree**: Created via `git worktree add ../wt-skill-146 -b feat/skill-146` from `main`. - [ ] **1.13c Implementation**: `src/game/skills/impl/bar/skill-146-battle-cry.ts` implements exact 1.13c `srvstfunc`/`srvdofunc`/`srvprgfunc` & numerical evaluation. - [ ] **Automated Unit & Numerical Tests (`slvl` 1, 10, 20 + `blvl` Synergies)**: `tests/skills/bar/skill-146-battle-cry.test.ts` passes 100% in Vitest verifying `ManaCost`, `MinDmg`, `MaxDmg`, `ToHit`, `Duration`, `Radius`, synergy scaling, and runtime combat/missile/state/summon effect. - [ ] **Real-Browser Casting & Screenshot**: Executed in headless Chromium (`acts.html?arena=1&class=bar&skill=146&slvl=20&autocast=1`) with zero console/page errors and PNG screenshot attached to this Issue. - [ ] **Merge & Cleanup**: Merged to `main` with `fixes #<issue_number>`, pushed to `origin/main`, verified Issue is `closed`, and removed worktree `../wt-skill-146` + branch `feat/skill-146`.
skill-146-battle-cry.png
573 KiB
skill-146-battle-cry.png
troytt added this to the All Player Skills (v1.13c Parity) milestone 2026-09-22 02:40:19 +00:00
troytt commented 2026-09-22 03:54:03 +00:00
Author
Owner
Copy Link

✅ Completed: [Skill #146] Battle Cry (BAR) — 1.13c Parity Verified

1. Isolated Worktree & Module Implementation

  • Worktree & Branch: ../wt-skill-146 (feat/skill-146)
  • Skill Module: src/game/skills/impl/bar/skill-146-battle-cry.ts
  • Vitest Suite: tests/skills/bar/skill-146-battle-cry.test.ts
  • 1.13c Dispatch: srvstfunc=0, srvdofunc=68, missile=battlecry, state=none, summon=none

2. 1.13c Numerical & Synergy Verification Table

Metric slvl = 1 slvl = 10 slvl = 20 (0 Syn) slvl = 20 (+20 blvl Syn)
Mana Cost (usmc) 5 (1280) 5 (1280) 5 (1280) 5 (1280)
Phys Dmg (Min-Max) 0-0 0-0 0-0 0-0
Elem Dmg (Min-Max) 0-0 (mag) 0-0 (mag) 0-0 (mag) 0-0 (+0%)
AR % / Duration / Radius +0% / 300f / 300 +0% / 840f / 840 +0% / 1440f / 1440 +0% / 1440f / 1440

3. Headless Chromium (chromium-1228) Runtime Telemetry & Screenshot

  • Arena State: ready=true, classCode=bar (ba), castCount=1, anim=SC:9, totalDamageDealt=0, consoleErrors=0
  • Captured PNG Size: 587195 bytes

Skill #146 Battle Cry

### ✅ Completed: [Skill #146] Battle Cry (`BAR`) — 1.13c Parity Verified #### 1. Isolated Worktree & Module Implementation - **Worktree & Branch**: `../wt-skill-146` (`feat/skill-146`) - **Skill Module**: `src/game/skills/impl/bar/skill-146-battle-cry.ts` - **Vitest Suite**: `tests/skills/bar/skill-146-battle-cry.test.ts` - **1.13c Dispatch**: `srvstfunc=0`, `srvdofunc=68`, `missile=battlecry`, `state=none`, `summon=none` #### 2. 1.13c Numerical & Synergy Verification Table | Metric | `slvl = 1` | `slvl = 10` | `slvl = 20` (0 Syn) | `slvl = 20` (+20 `blvl` Syn) | | :--- | :---: | :---: | :---: | :---: | | **Mana Cost (`usmc`)** | `5` (`1280`) | `5` (`1280`) | `5` (`1280`) | `5` (`1280`) | | **Phys Dmg (`Min-Max`)** | `0-0` | `0-0` | `0-0` | `0-0` | | **Elem Dmg (`Min-Max`)** | `0-0` (`mag`) | `0-0` (`mag`) | `0-0` (`mag`) | `0-0` (+0%) | | **AR % / Duration / Radius** | `+0%` / `300f` / `300` | `+0%` / `840f` / `840` | `+0%` / `1440f` / `1440` | `+0%` / `1440f` / `1440` | #### 3. Headless Chromium (`chromium-1228`) Runtime Telemetry & Screenshot - **Arena State**: `ready=true`, `classCode=bar` (`ba`), `castCount=1`, `anim=SC:9`, `totalDamageDealt=0`, `consoleErrors=0` - **Captured PNG Size**: `587195` bytes ![Skill #146 Battle Cry](https://git.projectdiablo2.cn/attachments/5b6e32b6-5191-4bac-9551-b838f5331b81)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
All Player Skills (v1.13c Parity)
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: troytt/diablo2-web#300
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?