troytt
/
diablo2-web
1
0
Fork 0
Code Issues 12 Pull Requests Packages Projects Releases Wiki Activity

[Milestone M7] Paladin Combat Skills Tree (Skills 96, 97, 101, 106, 107, 111, 112, 116, 117, 121) #446

New Issue
Closed
opened 2026-09-24 11:37:37 +00:00 by troytt · 1 comment
troytt commented 2026-09-24 11:37:37 +00:00
Owner
Copy Link

High-Level Goal

Implement all 10 Paladin Combat Skills with Diablo II v1.13c ground truth parity.

Scope of 10 Skills

  • Sacrifice (96): Physical damage + AR, 8% self-damage recoil with blood1 overlay.
  • Smite (97): 100% chance to hit (bypasses defense check), Stun duration, knockback, shield damage + Holy Shield scaling.
  • Holy Bolt (101): Magic damage strictly to Undead; heals friendly units; ignores living/demons.
  • Zeal (106): 1..5 rapid attack cycle (caps at 5 at lvl 5+).
  • Charge (107): High-speed 2:1 isometric rush, knockback, wall/collision stopping.
  • Vengeance (111): Tri-elemental damage % (Fire, Cold, Lightning) of physical weapon damage.
  • Blessed Hammer (112): Magic spiral trajectory in 2:1 iso ground space, CRITICAL 1.13c rule: DOES NOT ignore Undead/Demon magic resistance; Concentration aura synergy (+50% bonus).
  • Conversion (116): 16s temporary monster conversion, boss/champ immunity.
  • Holy Shield (117): Enhanced block % (up to 75% cap), Smite damage boost, fast 2-frame blocking, defense %.
  • Fist of the Heavens (121): Direct targeted lightning strike + radial Holy Bolt burst on Undead.

Invariants

  • BATCH1_SKILLS length = 38
  • ISO_GROUND_ASPECT_RATIO = 0.5

Quality Gate

  • Full 5-agent gate audit before merge.
## High-Level Goal Implement all 10 Paladin Combat Skills with Diablo II v1.13c ground truth parity. ## Scope of 10 Skills - **Sacrifice (96)**: Physical damage + AR, 8% self-damage recoil with blood1 overlay. - **Smite (97)**: 100% chance to hit (bypasses defense check), Stun duration, knockback, shield damage + Holy Shield scaling. - **Holy Bolt (101)**: Magic damage strictly to Undead; heals friendly units; ignores living/demons. - **Zeal (106)**: 1..5 rapid attack cycle (caps at 5 at lvl 5+). - **Charge (107)**: High-speed 2:1 isometric rush, knockback, wall/collision stopping. - **Vengeance (111)**: Tri-elemental damage % (Fire, Cold, Lightning) of physical weapon damage. - **Blessed Hammer (112)**: Magic spiral trajectory in 2:1 iso ground space, CRITICAL 1.13c rule: DOES NOT ignore Undead/Demon magic resistance; Concentration aura synergy (+50% bonus). - **Conversion (116)**: 16s temporary monster conversion, boss/champ immunity. - **Holy Shield (117)**: Enhanced block % (up to 75% cap), Smite damage boost, fast 2-frame blocking, defense %. - **Fist of the Heavens (121)**: Direct targeted lightning strike + radial Holy Bolt burst on Undead. ## Invariants - `BATCH1_SKILLS` length = 38 - `ISO_GROUND_ASPECT_RATIO = 0.5` ## Quality Gate - Full 5-agent gate audit before merge.
troytt commented 2026-09-24 13:46:54 +00:00
Author
Owner
Copy Link

Milestone M7: Paladin Combat Skills Tree - Complete & Merged

Merge & Upstream Push Verification:

  • Merge Commit (HEAD): bafa83df557eab7dbec0bfce52c96ca2be7d16a0
  • Rebase Base: Rebased cleanly onto origin/main (62f4b4172ec9ddb471e39cb338da4545163110a7)
  • Push Status: Pushed to origin/main successfully via fast-forward merge (62f4b41..bafa83d)

Test & Verification Evidence:

  • Paladin Combat Suite: tests/skills/pal/combat.test.ts (17/17 passed)
  • Cross-Tree Integration: tests/skills/sor/adv-cold-fire-e2e-integration.test.ts (20/20 passed)
  • Batch 1 Regressions: tests/skills-batch1.test.ts (26/26 passed)
  • TypeScript Typecheck: npm run typecheck (tsc --noEmit) clean (0 errors)
  • Full-Repo Test Failure Diff: 0 across 5,041 tests (no new test failures introduced)

Teamwork-Preview 5-Agent Gate Approval:

  • Reviewer 1: APPROVED (Architectural parity and 1.13c formula alignment confirmed)
  • Reviewer 2: APPROVED (Missile mechanics, mana shift, frame calculations verified)
  • Challenger 1: PASS (Dual-tree stress testing, immunity edge cases pass)
  • Challenger 2: PASS (Combat pipeline stress and attack rating checks pass)
  • Forensic Auditor: CLEAN (Strict symlink hygiene, no stray commits or file corruption)

Worktree Hygiene:

  • Symlinks safely detached (samples/d2, samples/d2-packs)
  • Worktree .worktrees/paladin-combat removed and pruned
  • Feature branch feat/paladin-combat cleanly deleted
### Milestone M7: Paladin Combat Skills Tree - Complete & Merged **Merge & Upstream Push Verification:** - **Merge Commit (HEAD)**: `bafa83df557eab7dbec0bfce52c96ca2be7d16a0` - **Rebase Base**: Rebased cleanly onto `origin/main` (`62f4b4172ec9ddb471e39cb338da4545163110a7`) - **Push Status**: Pushed to `origin/main` successfully via fast-forward merge (`62f4b41..bafa83d`) **Test & Verification Evidence:** - **Paladin Combat Suite**: `tests/skills/pal/combat.test.ts` (17/17 passed) - **Cross-Tree Integration**: `tests/skills/sor/adv-cold-fire-e2e-integration.test.ts` (20/20 passed) - **Batch 1 Regressions**: `tests/skills-batch1.test.ts` (26/26 passed) - **TypeScript Typecheck**: `npm run typecheck` (`tsc --noEmit`) clean (0 errors) - **Full-Repo Test Failure Diff**: `0` across 5,041 tests (no new test failures introduced) **Teamwork-Preview 5-Agent Gate Approval:** - **Reviewer 1**: APPROVED (Architectural parity and 1.13c formula alignment confirmed) - **Reviewer 2**: APPROVED (Missile mechanics, mana shift, frame calculations verified) - **Challenger 1**: PASS (Dual-tree stress testing, immunity edge cases pass) - **Challenger 2**: PASS (Combat pipeline stress and attack rating checks pass) - **Forensic Auditor**: CLEAN (Strict symlink hygiene, no stray commits or file corruption) **Worktree Hygiene:** - Symlinks safely detached (`samples/d2`, `samples/d2-packs`) - Worktree `.worktrees/paladin-combat` removed and pruned - Feature branch `feat/paladin-combat` cleanly deleted
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: troytt/diablo2-web#446
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?