troytt
/
diablo2-web
1
0
Fork 0
Code Issues 12 Pull Requests Packages Projects Releases Wiki Activity

[Milestone M12] Amazon Bow and Crossbow Skills Tree (Skills 6, 7, 11, 12, 16, 21, 22, 26, 27, 31) #459

New Issue
Closed
opened 2026-09-24 18:27:45 +00:00 by troytt · 1 comment
troytt commented 2026-09-24 18:27:45 +00:00
Owner
Copy Link

Goal

Comprehensive implementation of all 10 Amazon Bow and Crossbow Skills per Blizzard Diablo II v1.13c ground truth in isolated worktree .worktrees/amazon-bow.

Skills in Scope (10 Skills)

  1. Magic Arrow (ID 6): Mana conversion, physical-to-magic damage transformation, diminishing return mana cost down to 0 at slvl 13+, attack rating bonus.
  2. Fire Arrow (ID 7): Physical-to-fire damage conversion, additive fire damage, Exploding Arrow synergy (+12% fire damage / level).
  3. Cold Arrow (ID 11): Physical-to-cold damage conversion, flat cold damage, chill duration (frames), Ice Arrow synergy (+12% cold damage / level).
  4. Multiple Shot (ID 12): Multi-arrow fan kinematics, arrow count scaling (min(slvl + 1, 24)), 3/4 weapon damage penalty (HitShift = 6), only middle 2 arrows carrying CTC/leech per 1.13c.
  5. Exploding Arrow (ID 16): Fire damage blast radius (2 yards / 2.67 sub-tiles), fire arrow synergy (+12% fire damage / level), 100% splash on hit/pierce.
  6. Ice Arrow (ID 21): Single-target freeze duration, cold arrow synergy (+8% cold damage, +5% freeze length / level), cold missile kinematics.
  7. Guided Arrow (ID 22): Homing trajectory mechanics, 3/4 weapon damage (HitShift = 6 in 1.13c), cannot pierce in 1.13c (Pierce = 0 ground truth), physical damage bonus scaling.
  8. Strafe (ID 26): Multi-target lock-on sequence, arrow count calculation (min(slvl + 4, 10)), minimum arrows = 4, 3/4 weapon damage penalty (HitShift = 6), animation lock & next-hit delay (4 frames).
  9. Immolation Arrow (ID 27): Impact fire explosion + burning fire patches (duration 3 seconds / 75 frames), casting delay (1.0 second / 25 frames), synergies with Fire Arrow (+8% fire damage / level) and Exploding Arrow (+5% fire burn / level).
  10. Freezing Arrow (ID 31): Ice blast explosion radius (3.33 yards / 3 sub-tiles), 100% area freeze (2.0s baseline normal, difficulty scaling), synergies with Cold Arrow (+12% cold damage / level) and Ice Arrow (+5% freeze length / level).

Architecture & Ground Truth Requirements

  • Ground Truth Invariant: Strictly conform to Blizzard v1.13c assembly and Excel tables (Skills.txt, Missiles.txt, ItemStatCost.txt).
  • Projectile Kinematics & Collisions: 2:1 isometric coordinate projection, projectile velocities, sub-tile collision detection, and blast radii.
  • Pierce & Synergy Interactions: Correct handling of Pierce (Skill #33) with elemental splash arrows (Exploding Arrow, Immolation Arrow, Freezing Arrow triggering AoE on every pierced entity).
  • Damage Calculation Pipeline: Accurate weapon damage scalar, off-weapon %ED, elemental conversion vs additive elemental packets, NextDelay handling.
  • Workspace Isolation: Development strictly in .worktrees/amazon-bow with symlinks (samples/d2, samples/d2-packs) created without trailing slashes.

Acceptance Criteria

  • All 10 Bow & Crossbow skills implemented with authentic 1.13c formulas, synergies, and kinematics.
  • Comprehensive unit test suite in tests/skills/ama/ covering slvl 1/10/20, synergy scaling, and combat interactions.
  • Clean typecheck (tsc --noEmit) and 100% passing tests with zero regressions on existing suites.
  • Full 5-agent gate review (Reviewer 1, Reviewer 2, Challenger 1, Challenger 2, Forensic Auditor) unanimous approval.
### Goal Comprehensive implementation of all 10 **Amazon Bow and Crossbow Skills** per Blizzard Diablo II v1.13c ground truth in isolated worktree `.worktrees/amazon-bow`. ### Skills in Scope (10 Skills) 1. **Magic Arrow (ID 6)**: Mana conversion, physical-to-magic damage transformation, diminishing return mana cost down to 0 at slvl 13+, attack rating bonus. 2. **Fire Arrow (ID 7)**: Physical-to-fire damage conversion, additive fire damage, Exploding Arrow synergy (+12% fire damage / level). 3. **Cold Arrow (ID 11)**: Physical-to-cold damage conversion, flat cold damage, chill duration (frames), Ice Arrow synergy (+12% cold damage / level). 4. **Multiple Shot (ID 12)**: Multi-arrow fan kinematics, arrow count scaling (min(slvl + 1, 24)), 3/4 weapon damage penalty (HitShift = 6), only middle 2 arrows carrying CTC/leech per 1.13c. 5. **Exploding Arrow (ID 16)**: Fire damage blast radius (2 yards / 2.67 sub-tiles), fire arrow synergy (+12% fire damage / level), 100% splash on hit/pierce. 6. **Ice Arrow (ID 21)**: Single-target freeze duration, cold arrow synergy (+8% cold damage, +5% freeze length / level), cold missile kinematics. 7. **Guided Arrow (ID 22)**: Homing trajectory mechanics, 3/4 weapon damage (HitShift = 6 in 1.13c), cannot pierce in 1.13c (Pierce = 0 ground truth), physical damage bonus scaling. 8. **Strafe (ID 26)**: Multi-target lock-on sequence, arrow count calculation (min(slvl + 4, 10)), minimum arrows = 4, 3/4 weapon damage penalty (HitShift = 6), animation lock & next-hit delay (4 frames). 9. **Immolation Arrow (ID 27)**: Impact fire explosion + burning fire patches (duration 3 seconds / 75 frames), casting delay (1.0 second / 25 frames), synergies with Fire Arrow (+8% fire damage / level) and Exploding Arrow (+5% fire burn / level). 10. **Freezing Arrow (ID 31)**: Ice blast explosion radius (3.33 yards / 3 sub-tiles), 100% area freeze (2.0s baseline normal, difficulty scaling), synergies with Cold Arrow (+12% cold damage / level) and Ice Arrow (+5% freeze length / level). ### Architecture & Ground Truth Requirements - **Ground Truth Invariant:** Strictly conform to Blizzard v1.13c assembly and Excel tables (`Skills.txt`, `Missiles.txt`, `ItemStatCost.txt`). - **Projectile Kinematics & Collisions:** 2:1 isometric coordinate projection, projectile velocities, sub-tile collision detection, and blast radii. - **Pierce & Synergy Interactions:** Correct handling of Pierce (Skill #33) with elemental splash arrows (Exploding Arrow, Immolation Arrow, Freezing Arrow triggering AoE on every pierced entity). - **Damage Calculation Pipeline:** Accurate weapon damage scalar, off-weapon %ED, elemental conversion vs additive elemental packets, NextDelay handling. - **Workspace Isolation:** Development strictly in `.worktrees/amazon-bow` with symlinks (`samples/d2`, `samples/d2-packs`) created without trailing slashes. ### Acceptance Criteria - [ ] All 10 Bow & Crossbow skills implemented with authentic 1.13c formulas, synergies, and kinematics. - [ ] Comprehensive unit test suite in `tests/skills/ama/` covering slvl 1/10/20, synergy scaling, and combat interactions. - [ ] Clean typecheck (`tsc --noEmit`) and 100% passing tests with zero regressions on existing suites. - [ ] Full 5-agent gate review (Reviewer 1, Reviewer 2, Challenger 1, Challenger 2, Forensic Auditor) unanimous approval.
troytt commented 2026-09-24 19:27:29 +00:00
Author
Owner
Copy Link

Milestone M12: Amazon Bow and Crossbow Skills Tree — Completed & Verified

Milestone M12 has been successfully completed, verified, fast-forward merged to main, and pushed to upstream repository.

1. Merged Commit Hash

  • Commit: 52b0bbaf2b50728a646ef5fd0d10eb1a35f2510e (short 52b0bba)
  • Merge Strategy: Fast-forward merge (git merge --ff-only feat/amazon-bow)
  • Upstream Push: Pushed to origin/main (e3f03b2..52b0bba)

2. Full 5-Agent Unanimous Gate Approvals

  • Reviewer 1: APPROVED (full code parity, damage formulas, skills registry registration)
  • Reviewer 2: APPROVED (kinematics, trajectory projection, missile lifecycle, architecture conformance)
  • Challenger 1: PASS (14/14 stress tests in adv-ama-bow-kinematics-stress.test.ts)
  • Challenger 2: PASS (163/163 boundary and regression tests across Amazon skill suite)
  • Forensic Auditor: CLEAN (463/463 tests passing across 75 test files, 0 mock regressions, BATCH1_SKILLS length = 38)

3. Test Pass Evidence Across All 10 Amazon Bow & Crossbow Skills (1.13c Ground Truth)

  • Skill #006 Magic Arrow: Authentic mana conversion, physical-to-magic scaling, 0 mana cost at slvl 13+, weaponless damage handling.
  • Skill #007 Fire Arrow: Physical-to-fire conversion, additive fire damage, Exploding Arrow (+12%/lvl) synergy.
  • Skill #011 Cold Arrow: Physical-to-cold conversion, flat cold damage, chill duration, Ice Arrow (+12%/lvl) synergy.
  • Skill #012 Multiple Shot: Dynamic fan kinematics, arrow count min(slvl + 1, 24), 3/4 weapon damage (HitShift = 6), middle two arrows carrying CTC/leech per 1.13c.
  • Skill #016 Exploding Arrow: Area fire damage blast radius (2 yards / 2.67 sub-tiles), Fire Arrow (+12%/lvl) synergy, 100% splash on hit/pierce.
  • Skill #021 Ice Arrow: Single-target freeze duration, Cold Arrow (+8% cold dmg, +5% freeze length/lvl) synergies, cold missile kinematics.
  • Skill #022 Guided Arrow: Dynamic homing trajectory, isolated maxTurn clamp, 3/4 weapon damage (HitShift = 6), Pierce = 0 invariant per 1.13c ground truth.
  • Skill #026 Strafe: Multi-target lock-on sequence, arrow count min(slvl + 4, 10), 3/4 weapon damage penalty, NextHitDelay (4 frames).
  • Skill #027 Immolation Arrow: Impact explosion + burning fire patches (duration 3s / 75 frames), 1.0s cast delay, Fire Arrow (+8%/lvl) and Exploding Arrow (+5%/lvl) synergies.
  • Skill #031 Freezing Arrow: Area freeze explosion (3.33 yards / 3 sub-tiles), Cold Arrow (+12%/lvl) and Ice Arrow (+5%/lvl) synergies.

4. Worktree Cleanup

  • Removed temporary worktree symlinks without trailing slash.
  • Removed worktree .worktrees/amazon-bow and pruned git worktrees.
  • Deleted local branch feat/amazon-bow.
### Milestone M12: Amazon Bow and Crossbow Skills Tree — Completed & Verified Milestone M12 has been successfully completed, verified, fast-forward merged to `main`, and pushed to upstream repository. #### 1. Merged Commit Hash - **Commit:** `52b0bbaf2b50728a646ef5fd0d10eb1a35f2510e` (short `52b0bba`) - **Merge Strategy:** Fast-forward merge (`git merge --ff-only feat/amazon-bow`) - **Upstream Push:** Pushed to `origin/main` (e3f03b2..52b0bba) #### 2. Full 5-Agent Unanimous Gate Approvals - **Reviewer 1:** APPROVED (full code parity, damage formulas, skills registry registration) - **Reviewer 2:** APPROVED (kinematics, trajectory projection, missile lifecycle, architecture conformance) - **Challenger 1:** PASS (14/14 stress tests in `adv-ama-bow-kinematics-stress.test.ts`) - **Challenger 2:** PASS (163/163 boundary and regression tests across Amazon skill suite) - **Forensic Auditor:** CLEAN (463/463 tests passing across 75 test files, 0 mock regressions, BATCH1_SKILLS length = 38) #### 3. Test Pass Evidence Across All 10 Amazon Bow & Crossbow Skills (1.13c Ground Truth) - **Skill #006 Magic Arrow:** Authentic mana conversion, physical-to-magic scaling, 0 mana cost at slvl 13+, weaponless damage handling. - **Skill #007 Fire Arrow:** Physical-to-fire conversion, additive fire damage, Exploding Arrow (+12%/lvl) synergy. - **Skill #011 Cold Arrow:** Physical-to-cold conversion, flat cold damage, chill duration, Ice Arrow (+12%/lvl) synergy. - **Skill #012 Multiple Shot:** Dynamic fan kinematics, arrow count `min(slvl + 1, 24)`, 3/4 weapon damage (HitShift = 6), middle two arrows carrying CTC/leech per 1.13c. - **Skill #016 Exploding Arrow:** Area fire damage blast radius (2 yards / 2.67 sub-tiles), Fire Arrow (+12%/lvl) synergy, 100% splash on hit/pierce. - **Skill #021 Ice Arrow:** Single-target freeze duration, Cold Arrow (+8% cold dmg, +5% freeze length/lvl) synergies, cold missile kinematics. - **Skill #022 Guided Arrow:** Dynamic homing trajectory, isolated `maxTurn` clamp, 3/4 weapon damage (HitShift = 6), Pierce = 0 invariant per 1.13c ground truth. - **Skill #026 Strafe:** Multi-target lock-on sequence, arrow count `min(slvl + 4, 10)`, 3/4 weapon damage penalty, NextHitDelay (4 frames). - **Skill #027 Immolation Arrow:** Impact explosion + burning fire patches (duration 3s / 75 frames), 1.0s cast delay, Fire Arrow (+8%/lvl) and Exploding Arrow (+5%/lvl) synergies. - **Skill #031 Freezing Arrow:** Area freeze explosion (3.33 yards / 3 sub-tiles), Cold Arrow (+12%/lvl) and Ice Arrow (+5%/lvl) synergies. #### 4. Worktree Cleanup - Removed temporary worktree symlinks without trailing slash. - Removed worktree `.worktrees/amazon-bow` and pruned git worktrees. - Deleted local branch `feat/amazon-bow`.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: troytt/diablo2-web#459
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?