troytt
/
diablo2-web
1
0
Fork 0
Code Issues 12 Pull Requests Packages Projects Releases Wiki Activity

[Milestone M13] Amazon Passive and Magic Skills Tree (Skills 8, 9, 13, 17, 18, 23, 28, 32, 33, 34) #460

New Issue
Closed
opened 2026-09-24 19:27:29 +00:00 by troytt · 1 comment
troytt commented 2026-09-24 19:27:29 +00:00
Owner
Copy Link

Goal

Comprehensive implementation of all 10 Amazon Passive and Magic Skills per Blizzard Diablo II v1.13c ground truth in isolated worktree .worktrees/amazon-passive-magic.

Skills in Scope (10 Skills)

  1. Inner Sight (ID 8): Illuminates monsters within radius and reduces monster flat defense; duration, radius, and defense reduction scaling per 1.13c (Skills.txt).
  2. Critical Strike (ID 9): Passive chance for physical attacks to deal double physical damage ((slvl * 100) / (slvl + 10) diminishing returns curve).
  3. Dodge (ID 13): Passive chance to dodge melee attacks while standing or attacking ((slvl * 100) / (slvl + 10) curve); triggers Dodge animation lock frames.
  4. Slow Missiles (ID 17): Illuminates area and slows all enemy missile velocities within radius down to 33% normal speed; duration and radius scaling per 1.13c.
  5. Avoid (ID 18): Passive chance to avoid ranged/missile attacks while standing or attacking ((slvl * 100) / (slvl + 10) curve); triggers Avoid animation lock frames.
  6. Penetrate (ID 23): Passive Attack Rating bonus percentage (35 + 10 * (slvl - 1) / 10% per level after slvl 1).
  7. Decoy (ID 28): Summons an immobile illusion clone copy of the Amazon; life scaling based on caster base life + synergy bonuses; inherent resistances; monster threat distraction AI.
  8. Evade (ID 32): Passive chance to dodge any melee or missile attack while moving/walking/running ((slvl * 100) / (slvl + 10) curve); triggers Evade animation lock frames.
  9. Valkyrie (ID 33): Summons an autonomous powerful Valkyrie warrior; authentic 1.13c life, attack rating, defense, resistances, and procedural equipment tier generation based on slvl; synergy scaling with Decoy (+20% life/lvl), Penetrate (+40 AR/lvl), Dodge (+2% Dodge/lvl), Avoid (+2% Avoid/lvl), Evade (+2% Evade/lvl), and Critical Strike.
  10. Pierce (ID 34): Passive chance for missile attacks (arrows, bolts, javelins) to pass through enemies and continue on trajectory ((slvl * 100) / (slvl + 10) curve), enabling multi-hit splash triggers for applicable skills.

Architecture & Ground Truth Requirements

  • Ground Truth Invariant: Strictly conform to Blizzard v1.13c decompiled assembly and Excel tables (Skills.txt, Missiles.txt, MonStats.txt, ItemStatCost.txt).
  • Passive Defense & Evasion Integration: Integration with combat-pipeline.ts for Dodge (melee stationary), Avoid (ranged stationary), and Evade (in-motion) evasion checks and animation state interruptions.
  • Missile Engine Integration: Velocity scalar dampening for Slow Missiles; Pierce roll pipeline integration in missile trajectory and collision processing.
  • Minion Summon Lifecycle: Proper summon AI contracts, life scaling, threat aggro, and synergy scaling for Decoy and Valkyrie.
  • Workspace Isolation: Development strictly in .worktrees/amazon-passive-magic with symlinks (samples/d2, samples/d2-packs) created without trailing slashes.

Acceptance Criteria

  • All 10 Passive and Magic skills implemented with authentic 1.13c formulas, synergies, and passive/active combat mechanics.
  • Comprehensive unit test suite in tests/skills/ama/ covering slvl 1/10/20, synergy scaling, and combat/minion interactions.
  • Clean typecheck (tsc --noEmit) and 100% passing tests with zero regressions on existing suites.
  • Full 5-agent gate review (Reviewer 1, Reviewer 2, Challenger 1, Challenger 2, Forensic Auditor) unanimous approval.
### Goal Comprehensive implementation of all 10 **Amazon Passive and Magic Skills** per Blizzard Diablo II v1.13c ground truth in isolated worktree `.worktrees/amazon-passive-magic`. ### Skills in Scope (10 Skills) 1. **Inner Sight (ID 8)**: Illuminates monsters within radius and reduces monster flat defense; duration, radius, and defense reduction scaling per 1.13c (`Skills.txt`). 2. **Critical Strike (ID 9)**: Passive chance for physical attacks to deal double physical damage (`(slvl * 100) / (slvl + 10)` diminishing returns curve). 3. **Dodge (ID 13)**: Passive chance to dodge melee attacks while standing or attacking (`(slvl * 100) / (slvl + 10)` curve); triggers Dodge animation lock frames. 4. **Slow Missiles (ID 17)**: Illuminates area and slows all enemy missile velocities within radius down to 33% normal speed; duration and radius scaling per 1.13c. 5. **Avoid (ID 18)**: Passive chance to avoid ranged/missile attacks while standing or attacking (`(slvl * 100) / (slvl + 10)` curve); triggers Avoid animation lock frames. 6. **Penetrate (ID 23)**: Passive Attack Rating bonus percentage (`35 + 10 * (slvl - 1)` / 10% per level after slvl 1). 7. **Decoy (ID 28)**: Summons an immobile illusion clone copy of the Amazon; life scaling based on caster base life + synergy bonuses; inherent resistances; monster threat distraction AI. 8. **Evade (ID 32)**: Passive chance to dodge any melee or missile attack while moving/walking/running (`(slvl * 100) / (slvl + 10)` curve); triggers Evade animation lock frames. 9. **Valkyrie (ID 33)**: Summons an autonomous powerful Valkyrie warrior; authentic 1.13c life, attack rating, defense, resistances, and procedural equipment tier generation based on slvl; synergy scaling with Decoy (+20% life/lvl), Penetrate (+40 AR/lvl), Dodge (+2% Dodge/lvl), Avoid (+2% Avoid/lvl), Evade (+2% Evade/lvl), and Critical Strike. 10. **Pierce (ID 34)**: Passive chance for missile attacks (arrows, bolts, javelins) to pass through enemies and continue on trajectory (`(slvl * 100) / (slvl + 10)` curve), enabling multi-hit splash triggers for applicable skills. ### Architecture & Ground Truth Requirements - **Ground Truth Invariant:** Strictly conform to Blizzard v1.13c decompiled assembly and Excel tables (`Skills.txt`, `Missiles.txt`, `MonStats.txt`, `ItemStatCost.txt`). - **Passive Defense & Evasion Integration:** Integration with `combat-pipeline.ts` for Dodge (melee stationary), Avoid (ranged stationary), and Evade (in-motion) evasion checks and animation state interruptions. - **Missile Engine Integration:** Velocity scalar dampening for Slow Missiles; Pierce roll pipeline integration in missile trajectory and collision processing. - **Minion Summon Lifecycle:** Proper summon AI contracts, life scaling, threat aggro, and synergy scaling for Decoy and Valkyrie. - **Workspace Isolation:** Development strictly in `.worktrees/amazon-passive-magic` with symlinks (`samples/d2`, `samples/d2-packs`) created without trailing slashes. ### Acceptance Criteria - [ ] All 10 Passive and Magic skills implemented with authentic 1.13c formulas, synergies, and passive/active combat mechanics. - [ ] Comprehensive unit test suite in `tests/skills/ama/` covering slvl 1/10/20, synergy scaling, and combat/minion interactions. - [ ] Clean typecheck (`tsc --noEmit`) and 100% passing tests with zero regressions on existing suites. - [ ] Full 5-agent gate review (Reviewer 1, Reviewer 2, Challenger 1, Challenger 2, Forensic Auditor) unanimous approval.
troytt commented 2026-09-24 20:23:14 +00:00
Author
Owner
Copy Link

Milestone M13: Amazon Passive and Magic Skills Tree — Completed & Merged

1. Merged Commit

  • Main Commit: 3e4350e (3e4350e fix(ama): safely dereference owner stateBus in slow missiles tick (#460))
  • Feature Commit: 1e5b02f (1e5b02f feat(ama): implement Milestone M13 Amazon Passive and Magic skills tree (#460))
  • Status: Successfully fast-forward merged into main (52b0bba..3e4350e) and pushed to upstream origin/main.

2. 5-Agent Unanimous Gate Approvals

  • Reviewer 1: APPROVED (Architectural adherence, engine integration, zero type regressions)
  • Reviewer 2: APPROVED (1.13c ground truth parity, diminishing return curve formulas, equipment tiers)
  • Challenger 1: PASS (11/11 stress tests passing in tests/skills/ama/adv-ama-passive-magic-stress.test.ts)
  • Challenger 2: PASS (222/222 tests passing across 36 test files: tests/skills/ama/* + tests/skills-batch1.test.ts)
  • Forensic Auditor: CLEAN (0 mocks, BATCH1_SKILLS.length = 38 registered runtime skills, zero mock regressions)

3. Diablo II v1.13c Ground Truth Verification Summary (10/10 Skills)

  1. Inner Sight (8): Flat defense reduction (-40 - 20 * slvl), illuminated visual state, 13.8 yard base radius + 1.3 yards/lvl, duration 28s + 4.5s/lvl, monster defense reduction with floor at 0.
  2. Critical Strike (9): Passive double physical damage probability curve per Skills.txt (5% + 7%... diminishing returns).
  3. Dodge (13): Standing/attacking melee evasion check (18% + 6%... diminishing returns), triggers defensive action recovery animation.
  4. Slow Missiles (17): Projectile velocity throttled to 33% (target missile speed / 3 per Missiles.txt ground truth), illuminated state, radius 13.3 yards, duration 12s + 2.4s/lvl, robust null check on owner stateBus.
  5. Avoid (18): Standing/attacking ranged missile evasion check (13% + 7%... diminishing returns).
  6. Penetrate (23): Passive attack rating percentage boost (35% + 10%/lvl).
  7. Dopplezon / Decoy (28): Static mirror summon with Amazon player stats, level-scaled life (base * (1 + 0.1 * slvl)), monster distraction targeting AI, duration 10s + 5s/lvl, mana cost 19 - 1/lvl (min 1).
  8. Evade (29): Moving evasion check for both melee and missile attacks (13% + 5%... diminishing returns).
  9. Valkyrie (32): Dynamic Amazon warrior summon, stats scaling with Amazon passive synergies (+20% life per Decoy blvl, +40 attack rating per Penetrate blvl, +2% all res per Critical Strike blvl, +2% dodge/avoid/evade matching Amazon passive levels), equipment tiers at slvl 1, 4, 7, 10, 13, 16, 19, 23.
  10. Pierce (33): Passive missile piercing probability (10% + 13%... diminishing returns per Skills.txt).

4. Worktree Cleanup

  • Worktree .worktrees/amazon-passive-magic symlinks cleanly unlinked without trailing slashes.
  • Worktree removed and pruned; local branch feat/amazon-passive-magic deleted.
## Milestone M13: Amazon Passive and Magic Skills Tree — Completed & Merged ### 1. Merged Commit - **Main Commit**: `3e4350e` (`3e4350e fix(ama): safely dereference owner stateBus in slow missiles tick (#460)`) - **Feature Commit**: `1e5b02f` (`1e5b02f feat(ama): implement Milestone M13 Amazon Passive and Magic skills tree (#460)`) - **Status**: Successfully fast-forward merged into `main` (`52b0bba..3e4350e`) and pushed to upstream `origin/main`. ### 2. 5-Agent Unanimous Gate Approvals - **Reviewer 1**: APPROVED (Architectural adherence, engine integration, zero type regressions) - **Reviewer 2**: APPROVED (1.13c ground truth parity, diminishing return curve formulas, equipment tiers) - **Challenger 1**: PASS (11/11 stress tests passing in `tests/skills/ama/adv-ama-passive-magic-stress.test.ts`) - **Challenger 2**: PASS (222/222 tests passing across 36 test files: `tests/skills/ama/*` + `tests/skills-batch1.test.ts`) - **Forensic Auditor**: CLEAN (0 mocks, `BATCH1_SKILLS.length` = 38 registered runtime skills, zero mock regressions) ### 3. Diablo II v1.13c Ground Truth Verification Summary (10/10 Skills) 1. **Inner Sight (8)**: Flat defense reduction (`-40 - 20 * slvl`), illuminated visual state, 13.8 yard base radius + 1.3 yards/lvl, duration 28s + 4.5s/lvl, monster defense reduction with floor at 0. 2. **Critical Strike (9)**: Passive double physical damage probability curve per Skills.txt (`5% + 7%...` diminishing returns). 3. **Dodge (13)**: Standing/attacking melee evasion check (`18% + 6%...` diminishing returns), triggers defensive action recovery animation. 4. **Slow Missiles (17)**: Projectile velocity throttled to 33% (target missile speed / 3 per Missiles.txt ground truth), illuminated state, radius 13.3 yards, duration 12s + 2.4s/lvl, robust null check on owner `stateBus`. 5. **Avoid (18)**: Standing/attacking ranged missile evasion check (`13% + 7%...` diminishing returns). 6. **Penetrate (23)**: Passive attack rating percentage boost (`35% + 10%/lvl`). 7. **Dopplezon / Decoy (28)**: Static mirror summon with Amazon player stats, level-scaled life (`base * (1 + 0.1 * slvl)`), monster distraction targeting AI, duration 10s + 5s/lvl, mana cost 19 - 1/lvl (min 1). 8. **Evade (29)**: Moving evasion check for both melee and missile attacks (`13% + 5%...` diminishing returns). 9. **Valkyrie (32)**: Dynamic Amazon warrior summon, stats scaling with Amazon passive synergies (+20% life per Decoy blvl, +40 attack rating per Penetrate blvl, +2% all res per Critical Strike blvl, +2% dodge/avoid/evade matching Amazon passive levels), equipment tiers at slvl 1, 4, 7, 10, 13, 16, 19, 23. 10. **Pierce (33)**: Passive missile piercing probability (`10% + 13%...` diminishing returns per Skills.txt). ### 4. Worktree Cleanup - Worktree `.worktrees/amazon-passive-magic` symlinks cleanly unlinked without trailing slashes. - Worktree removed and pruned; local branch `feat/amazon-passive-magic` deleted.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: troytt/diablo2-web#460
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?