troytt
/
diablo2-web
1
0
Fork 0
Code Issues 12 Pull Requests Packages Projects Releases Wiki Activity

[Milestone M18] Barbarian Combat Masteries (Sword, Axe, Mace, Polearm, Throwing, Spear, Stamina, Iron Skin, Speed, Natural Resistance) #465

New Issue
Closed
opened 2026-09-25 01:58:30 +00:00 by troytt · 1 comment
troytt commented 2026-09-25 01:58:30 +00:00
Owner
Copy Link

Milestone M18: Barbarian Combat Masteries (10 Skills)

1. Overview & Scope

Implement authoritative Diablo II v1.13c pure calculations, passive stat progression, and adversarial testing for the 10 Barbarian Combat Masteries:

  • Skill 127: Sword Mastery
  • Skill 128: Axe Mastery
  • Skill 129: Mace Mastery
  • Skill 134: Polearm Mastery
  • Skill 135: Throwing Mastery
  • Skill 136: Spear Mastery
  • Skill 141: Increased Stamina
  • Skill 145: Iron Skin
  • Skill 148: Increased Speed
  • Skill 153: Natural Resistance

2. Authoritative 1.13c Ground Truth Formulas (Skills.txt)

  • Weapon Masteries (127, 128, 129, 134, 135, 136):
    • Swords/Axes/Maces (127-129): AR 28 + 8 * (slvl - 1)%, Dmg 28 + 5 * (slvl - 1)%, Crit dm(0, 35, slvl)%
    • Polearms/Throwing/Spears (134-136): AR 30 + 8 * (slvl - 1)%, Dmg 28 + 5 * (slvl - 1)%, Crit dm(0, 35, slvl)%
    • Critical strike stacks with Deadly Strike via sequential roll: CS + DS * (1 - CS) (cannot double-crit).
  • Increased Stamina (141):
    • Max Stamina bonus +30% + 15% * (slvl - 1)
  • Iron Skin (145):
    • Enhanced Defense +30% + 10% * (slvl - 1)
  • Increased Speed (148):
    • Run/Walk velocity %: dm(7, 50, slvl)
  • Natural Resistance (153):
    • All 4 elemental resistances (Fire/Cold/Light/Poison): dm(0, 80, slvl)

3. Acceptance Criteria

  • Dedicated calculation module src/game/skills/barbarian-masteries.ts
  • Adversarial stress test tests/skills/bar/adv-bar-masteries-stress.test.ts
  • Zero runtime MPQ reading
  • Strict BATCH1_SKILLS invariant length = 38
  • 100% tests pass and npm run typecheck passes with 0 errors
  • Worktree isolation and clean merge to main
## Milestone M18: Barbarian Combat Masteries (10 Skills) ### 1. Overview & Scope Implement authoritative Diablo II v1.13c pure calculations, passive stat progression, and adversarial testing for the 10 Barbarian Combat Masteries: - Skill 127: Sword Mastery - Skill 128: Axe Mastery - Skill 129: Mace Mastery - Skill 134: Polearm Mastery - Skill 135: Throwing Mastery - Skill 136: Spear Mastery - Skill 141: Increased Stamina - Skill 145: Iron Skin - Skill 148: Increased Speed - Skill 153: Natural Resistance ### 2. Authoritative 1.13c Ground Truth Formulas (Skills.txt) - **Weapon Masteries (127, 128, 129, 134, 135, 136)**: - Swords/Axes/Maces (127-129): AR `28 + 8 * (slvl - 1)%`, Dmg `28 + 5 * (slvl - 1)%`, Crit `dm(0, 35, slvl)%` - Polearms/Throwing/Spears (134-136): AR `30 + 8 * (slvl - 1)%`, Dmg `28 + 5 * (slvl - 1)%`, Crit `dm(0, 35, slvl)%` - Critical strike stacks with Deadly Strike via sequential roll: `CS + DS * (1 - CS)` (cannot double-crit). - **Increased Stamina (141)**: - Max Stamina bonus `+30% + 15% * (slvl - 1)` - **Iron Skin (145)**: - Enhanced Defense `+30% + 10% * (slvl - 1)` - **Increased Speed (148)**: - Run/Walk velocity `%`: `dm(7, 50, slvl)` - **Natural Resistance (153)**: - All 4 elemental resistances (Fire/Cold/Light/Poison): `dm(0, 80, slvl)` ### 3. Acceptance Criteria - [ ] Dedicated calculation module `src/game/skills/barbarian-masteries.ts` - [ ] Adversarial stress test `tests/skills/bar/adv-bar-masteries-stress.test.ts` - [ ] Zero runtime MPQ reading - [ ] Strict `BATCH1_SKILLS` invariant length = 38 - [ ] 100% tests pass and `npm run typecheck` passes with 0 errors - [ ] Worktree isolation and clean merge to `main`
troytt commented 2026-09-25 02:02:51 +00:00
Author
Owner
Copy Link

Milestone M18: Barbarian Combat Masteries — Verification & Landed Evidence

All 10 Barbarian Combat Masteries have been implemented, strictly verified against Diablo II v1.13c ground truth, and merged to main in commit 0c3388b.

Implemented Skills

  1. Sword Mastery (127): AR 28 + 8 * (slvl - 1)%, Dmg 28 + 5 * (slvl - 1)%, Crit dm(0, 35, slvl)%.
  2. Axe Mastery (128): AR 28 + 8 * (slvl - 1)%, Dmg 28 + 5 * (slvl - 1)%, Crit dm(0, 35, slvl)%.
  3. Mace Mastery (129): AR 28 + 8 * (slvl - 1)%, Dmg 28 + 5 * (slvl - 1)%, Crit dm(0, 35, slvl)%.
  4. Polearm Mastery (134): AR 30 + 8 * (slvl - 1)%, Dmg 28 + 5 * (slvl - 1)%, Crit dm(0, 35, slvl)%.
  5. Throwing Mastery (135): AR 30 + 8 * (slvl - 1)%, Dmg 28 + 5 * (slvl - 1)%, Crit dm(0, 35, slvl)%.
  6. Spear Mastery (136): AR 30 + 8 * (slvl - 1)%, Dmg 28 + 5 * (slvl - 1)%, Crit dm(0, 35, slvl)%.
  7. Increased Stamina (141): Stamina +30% + 15% * (slvl - 1).
  8. Iron Skin (145): Defense +30% + 10% * (slvl - 1).
  9. Increased Speed (148): Faster Run/Walk dm(7, 50, slvl)%.
  10. Natural Resistance (153): All 4 elemental resists dm(0, 80, slvl)%.

Auxiliary Mechanics

  • Weapon Category Matching: Verified detection for swords, axes, maces/hammers/scepters, polearms, throwing weapons, and spears.
  • Critical Strike + Deadly Strike Interaction: Enforces 1.13c sequential roll CS + DS * (1 - CS) without quadruple damage stacking.

Quality Gate Verification Results

  • tests/skills/bar/adv-bar-masteries-stress.test.ts: 16/16 tests passed
  • tests/skills/bar/: 34 test files, 140/140 tests passed
  • Full project test suite: 0 regressions
  • npm run typecheck: 0 errors
  • Invariant: BATCH1_SKILLS length strictly = 38
### Milestone M18: Barbarian Combat Masteries — Verification & Landed Evidence All 10 Barbarian Combat Masteries have been implemented, strictly verified against Diablo II v1.13c ground truth, and merged to `main` in commit `0c3388b`. #### Implemented Skills 1. **Sword Mastery (127)**: AR `28 + 8 * (slvl - 1)%`, Dmg `28 + 5 * (slvl - 1)%`, Crit `dm(0, 35, slvl)%`. 2. **Axe Mastery (128)**: AR `28 + 8 * (slvl - 1)%`, Dmg `28 + 5 * (slvl - 1)%`, Crit `dm(0, 35, slvl)%`. 3. **Mace Mastery (129)**: AR `28 + 8 * (slvl - 1)%`, Dmg `28 + 5 * (slvl - 1)%`, Crit `dm(0, 35, slvl)%`. 4. **Polearm Mastery (134)**: AR `30 + 8 * (slvl - 1)%`, Dmg `28 + 5 * (slvl - 1)%`, Crit `dm(0, 35, slvl)%`. 5. **Throwing Mastery (135)**: AR `30 + 8 * (slvl - 1)%`, Dmg `28 + 5 * (slvl - 1)%`, Crit `dm(0, 35, slvl)%`. 6. **Spear Mastery (136)**: AR `30 + 8 * (slvl - 1)%`, Dmg `28 + 5 * (slvl - 1)%`, Crit `dm(0, 35, slvl)%`. 7. **Increased Stamina (141)**: Stamina `+30% + 15% * (slvl - 1)`. 8. **Iron Skin (145)**: Defense `+30% + 10% * (slvl - 1)`. 9. **Increased Speed (148)**: Faster Run/Walk `dm(7, 50, slvl)%`. 10. **Natural Resistance (153)**: All 4 elemental resists `dm(0, 80, slvl)%`. #### Auxiliary Mechanics - **Weapon Category Matching**: Verified detection for swords, axes, maces/hammers/scepters, polearms, throwing weapons, and spears. - **Critical Strike + Deadly Strike Interaction**: Enforces 1.13c sequential roll `CS + DS * (1 - CS)` without quadruple damage stacking. #### Quality Gate Verification Results - `tests/skills/bar/adv-bar-masteries-stress.test.ts`: 16/16 tests passed - `tests/skills/bar/`: 34 test files, 140/140 tests passed - Full project test suite: 0 regressions - `npm run typecheck`: 0 errors - Invariant: `BATCH1_SKILLS` length strictly = 38
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: troytt/diablo2-web#465
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?