troytt
/
diablo2-web
1
0
Fork 0
Code Issues 12 Pull Requests Packages Projects Releases Wiki Activity

[Milestone M20] Barbarian Class Final Quality Gate & E2E Parity Audit (All 30 Skills, Assets, Kinematics, Synergies) #467

New Issue
Closed
opened 2026-09-25 02:09:09 +00:00 by troytt · 1 comment
troytt commented 2026-09-25 02:09:09 +00:00
Owner
Copy Link

Milestone M20: Barbarian Class Final Quality Gate (30/30 Skills)

1. Overview & Scope

Comprehensive class-wide verification across all 30 Barbarian skills (IDs 126–155) under Diablo II v1.13c ground truth:

  • Combat Skills (10 skills): Bash, Leap, Double Swing, Stun, Double Throw, Leap Attack, Concentrate, Frenzy, Whirlwind, Berserk.
  • Combat Masteries (10 skills): Sword, Axe, Mace, Polearm, Throwing, Spear, Stamina, Iron Skin, Speed, Natural Resistance.
  • Warcries (10 skills): Howl, Find Potion, Taunt, Shout, Find Item, Battle Cry, Battle Orders, Grim Ward, War Cry, Battle Command.

2. Multi-Dimensional Quality Gate Invariants

  • D1: Complete Skill Tree Coverage: All 30 Barbarian skills evaluate correctly across all 3 branches.
  • D2: Baked Visual Asset Parity: All Barbarian missile DCC animations (warcries, grim ward totems) and overlays (shout, battle orders, battle command, berserk, frenzy, warcry) present with valid metadata.
  • D3: Ground Truth Synergies & Kinematics: Cross-tree synergies (Shout/BO/BC duration links, War Cry damage, Berserk magic conversions, Frenzy move speed).
  • D4: Dual-Wield & Weapon Category Rules: Verification for swords, axes, maces, polearms, spears, throwing weapons, and dual-wield flags.
  • D5: Zero Runtime MPQ Invariant: 100% pre-baked sprite atlas assets.
  • D6: Strict BATCH1 Invariant: `BATCH1_SKILLS` length strictly = 38.

3. Acceptance Criteria

  • End-to-end audit test suite `tests/skills/bar/adv-bar-e2e-gate.test.ts`
  • Full project test suite passes with 0 regressions
  • `npm run typecheck` produces 0 errors
  • Clean merge to `main` and push to `origin/main`
## Milestone M20: Barbarian Class Final Quality Gate (30/30 Skills) ### 1. Overview & Scope Comprehensive class-wide verification across all 30 Barbarian skills (IDs 126–155) under Diablo II v1.13c ground truth: - **Combat Skills (10 skills)**: Bash, Leap, Double Swing, Stun, Double Throw, Leap Attack, Concentrate, Frenzy, Whirlwind, Berserk. - **Combat Masteries (10 skills)**: Sword, Axe, Mace, Polearm, Throwing, Spear, Stamina, Iron Skin, Speed, Natural Resistance. - **Warcries (10 skills)**: Howl, Find Potion, Taunt, Shout, Find Item, Battle Cry, Battle Orders, Grim Ward, War Cry, Battle Command. ### 2. Multi-Dimensional Quality Gate Invariants - **D1: Complete Skill Tree Coverage**: All 30 Barbarian skills evaluate correctly across all 3 branches. - **D2: Baked Visual Asset Parity**: All Barbarian missile DCC animations (warcries, grim ward totems) and overlays (shout, battle orders, battle command, berserk, frenzy, warcry) present with valid metadata. - **D3: Ground Truth Synergies & Kinematics**: Cross-tree synergies (Shout/BO/BC duration links, War Cry damage, Berserk magic conversions, Frenzy move speed). - **D4: Dual-Wield & Weapon Category Rules**: Verification for swords, axes, maces, polearms, spears, throwing weapons, and dual-wield flags. - **D5: Zero Runtime MPQ Invariant**: 100% pre-baked sprite atlas assets. - **D6: Strict BATCH1 Invariant**: \`BATCH1_SKILLS\` length strictly = 38. ### 3. Acceptance Criteria - [ ] End-to-end audit test suite \`tests/skills/bar/adv-bar-e2e-gate.test.ts\` - [ ] Full project test suite passes with 0 regressions - [ ] \`npm run typecheck\` produces 0 errors - [ ] Clean merge to \`main\` and push to \`origin/main\`
troytt commented 2026-09-25 02:13:36 +00:00
Author
Owner
Copy Link

Milestone M20: Barbarian Class Quality Gate & E2E Verification — Landed Evidence

All 30 Barbarian skills (IDs 126–155) across Combat Skills, Combat Masteries, and Warcries have passed full end-to-end integration and architectural quality gating under Diablo II v1.13c ground truth. Merged to main in commit 1f14b31.

Comprehensive Scenarios Verified

  1. Cross-Tree Buff Duration Network: Mutual duration synergy (+125 frames / 5s per blvl) for Shout, Battle Orders, Battle Command verified. Max synergized party buffs reach 410s (Shout) and 420s (Battle Orders).
  2. Berserk Magic Conversion & Vulnerability: 100% physical to magic conversion verified; vulnerability zero-defense duration reduction formula verified across slvl 1..20; Howl & Shout +10%/lvl synergies verified.
  3. Frenzy Dual-Wield Stacking: Dual-wielding requirement, speed caps, 150-frame (6.0s) buff timer, and Double Swing/Taunt/Berserk synergies verified.
  4. Whirlwind Area Sweeping: 1.13c authentic negative base scaling (-50% at slvl 1) up to +102% at slvl 20; 4-frame hit check frequency verified.
  5. War Cry Stun & Synergies: 5-band physical damage progression (20-30 base, +6/+7/+8/+9/+10), +6% damage / blvl, and stun duration verified.
  6. Combat Masteries: AR, %ED, and diminishing returns Critical Strike verified for all 6 weapon categories; non-quadrupling sequential roll with Deadly Strike verified.
  7. Corpse & Crowd Control Utilities: Find Potion, Find Item, Grim Ward (1000 frames totem life, fear radius), Taunt, and Battle Cry verified.
  8. 30/30 Barbarian Tree Registry & Invariants: All 30 skills verified in 1.13c Data Registry; BATCH1_SKILLS length invariant strictly = 38.

Test Results

  • tests/skills/bar/adv-bar-e2e-gate.test.ts: 9/9 scenarios passed
  • tests/skills/bar/: 36 test files, 167/167 tests passed
  • Full project test suite: 0 regressions
  • npm run typecheck: 0 errors
  • Invariant: BATCH1_SKILLS length strictly = 38
### Milestone M20: Barbarian Class Quality Gate & E2E Verification — Landed Evidence All 30 Barbarian skills (IDs 126–155) across Combat Skills, Combat Masteries, and Warcries have passed full end-to-end integration and architectural quality gating under Diablo II v1.13c ground truth. Merged to `main` in commit `1f14b31`. #### Comprehensive Scenarios Verified 1. **Cross-Tree Buff Duration Network**: Mutual duration synergy (+125 frames / 5s per blvl) for Shout, Battle Orders, Battle Command verified. Max synergized party buffs reach 410s (Shout) and 420s (Battle Orders). 2. **Berserk Magic Conversion & Vulnerability**: 100% physical to magic conversion verified; vulnerability zero-defense duration reduction formula verified across slvl 1..20; Howl & Shout +10%/lvl synergies verified. 3. **Frenzy Dual-Wield Stacking**: Dual-wielding requirement, speed caps, 150-frame (6.0s) buff timer, and Double Swing/Taunt/Berserk synergies verified. 4. **Whirlwind Area Sweeping**: 1.13c authentic negative base scaling (-50% at slvl 1) up to +102% at slvl 20; 4-frame hit check frequency verified. 5. **War Cry Stun & Synergies**: 5-band physical damage progression (20-30 base, +6/+7/+8/+9/+10), +6% damage / blvl, and stun duration verified. 6. **Combat Masteries**: AR, %ED, and diminishing returns Critical Strike verified for all 6 weapon categories; non-quadrupling sequential roll with Deadly Strike verified. 7. **Corpse & Crowd Control Utilities**: Find Potion, Find Item, Grim Ward (1000 frames totem life, fear radius), Taunt, and Battle Cry verified. 8. **30/30 Barbarian Tree Registry & Invariants**: All 30 skills verified in 1.13c Data Registry; `BATCH1_SKILLS` length invariant strictly = 38. #### Test Results - `tests/skills/bar/adv-bar-e2e-gate.test.ts`: 9/9 scenarios passed - `tests/skills/bar/`: 36 test files, 167/167 tests passed - Full project test suite: 0 regressions - `npm run typecheck`: 0 errors - Invariant: `BATCH1_SKILLS` length strictly = 38
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: troytt/diablo2-web#467
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?