troytt
/
diablo2-web
1
0
Fork 0
Code Issues 12 Pull Requests Packages Projects Releases Wiki Activity

[Milestone M27] Assassin Martial Arts (Charge-ups & Finishers, 10 skills) #474

New Issue
Closed
opened 2026-09-25 03:31:56 +00:00 by troytt · 1 comment
troytt commented 2026-09-25 03:31:56 +00:00
Owner
Copy Link

Milestone M27: Assassin Martial Arts (Charge-ups & Finishers, 10 skills)

Scope:

  1. Charge-up Mechanics & Progression (6 skills):

    • Tiger Strike (#254): 3-tier Enhanced Damage% progression (e.g. +100%, +200%, +300% base).
    • Fists of Fire (#259): Tier 1 (Fire damage), Tier 2 (Fire explosion radius), Tier 3 (Ground fire burning pool).
    • Cobra Strike (#265): Tier 1 (Life steal), Tier 2 (Life + Mana steal), Tier 3 (Double Life + Mana steal).
    • Claws of Thunder (#269): Tier 1 (Lightning damage), Tier 2 (Nova explosion), Tier 3 (Charged bolts).
    • Blades of Ice (#274): Tier 1 (Cold damage), Tier 2 (Ice explosion), Tier 3 (Freeze radius).
    • Royal Strike / Phoenix Strike (#280): Tier 1 (Meteor), Tier 2 (Chain Lightning), Tier 3 (Chaos Ice Orb).
    • Multi-skill charge stacking and 15s (375-frame) duration expiration.

  2. Finisher Moves & Discharge Engine (4 skills):

    • Dragon Talon (#255): Multi-kick sequence 1 + floor((slvl - 1) / 3) kicks, knockback, single-discharge on first connecting kick.
    • Dragon Claw (#260): Dual-claw requirement, two sequential hit checks, discharging charges on hit.
    • Dragon Tail (#270): Knockback kick with physical-to-fire explosion conversion.
    • Dragon Flight (#275): Teleport kick with targeting, 4-frame NextDelay, discharge on impact.

  3. Core Martial Arts Engine (src/game/skills/assassin-martial-arts.ts):

    • Charge state tracking container (ChargeOrbManager).
    • Finisher release resolution.
    • Dual-claw equipment validation (canCastDragonClaw).
    • Phoenix Strike tier selector.

  4. Adversarial Stress Test Suite (tests/skills/ass/adv-ass-martial-stress.test.ts):

    • 3-charge accumulation and 375-frame timeout.
    • Simultaneous multi-charge release (e.g. Tiger + Cobra + Phoenix).
    • Dragon Talon kick count progression and discharge gating.
    • Dragon Claw dual-claw strike logic.
    • 0 typecheck errors, 0 regressions across all 10 individual unit tests.
### Milestone M27: Assassin Martial Arts (Charge-ups & Finishers, 10 skills) #### Scope: 1. **Charge-up Mechanics & Progression (6 skills)**: - Tiger Strike (#254): 3-tier Enhanced Damage% progression (e.g. +100%, +200%, +300% base). - Fists of Fire (#259): Tier 1 (Fire damage), Tier 2 (Fire explosion radius), Tier 3 (Ground fire burning pool). - Cobra Strike (#265): Tier 1 (Life steal), Tier 2 (Life + Mana steal), Tier 3 (Double Life + Mana steal). - Claws of Thunder (#269): Tier 1 (Lightning damage), Tier 2 (Nova explosion), Tier 3 (Charged bolts). - Blades of Ice (#274): Tier 1 (Cold damage), Tier 2 (Ice explosion), Tier 3 (Freeze radius). - Royal Strike / Phoenix Strike (#280): Tier 1 (Meteor), Tier 2 (Chain Lightning), Tier 3 (Chaos Ice Orb). - Multi-skill charge stacking and 15s (375-frame) duration expiration. 2. **Finisher Moves & Discharge Engine (4 skills)**: - Dragon Talon (#255): Multi-kick sequence `1 + floor((slvl - 1) / 3)` kicks, knockback, single-discharge on first connecting kick. - Dragon Claw (#260): Dual-claw requirement, two sequential hit checks, discharging charges on hit. - Dragon Tail (#270): Knockback kick with physical-to-fire explosion conversion. - Dragon Flight (#275): Teleport kick with targeting, 4-frame NextDelay, discharge on impact. 3. **Core Martial Arts Engine (`src/game/skills/assassin-martial-arts.ts`)**: - Charge state tracking container (`ChargeOrbManager`). - Finisher release resolution. - Dual-claw equipment validation (`canCastDragonClaw`). - Phoenix Strike tier selector. 4. **Adversarial Stress Test Suite (`tests/skills/ass/adv-ass-martial-stress.test.ts`)**: - 3-charge accumulation and 375-frame timeout. - Simultaneous multi-charge release (e.g. Tiger + Cobra + Phoenix). - Dragon Talon kick count progression and discharge gating. - Dragon Claw dual-claw strike logic. - 0 typecheck errors, 0 regressions across all 10 individual unit tests.
troytt commented 2026-09-25 03:39:00 +00:00
Author
Owner
Copy Link

[Milestone M27] Assassin Martial Arts (Charge-ups & Finishers, 10 skills) — COMPLETE & VERIFIED

All 10 Assassin Martial Arts skills (#254 Tiger Strike, #255 Dragon Talon, #259 Fists of Fire, #260 Dragon Claw, #265 Cobra Strike, #269 Claws of Thunder, #270 Dragon Tail, #274 Blades of Ice, #275 Dragon Flight, #280 Phoenix Strike) have been implemented and verified with 1.13c parity.

Implementation Highlights:

  1. ChargeOrbManager:
    • 1..3 tier charge accumulation per charge-up skill, capped at 3 charges.
    • 375-frame (15.0s) duration lifetime with automatic expiration.
    • Lifetime refreshes upon adding additional charges before timeout.
    • Multi-skill charge orb coexistence simultaneously (Tiger Strike, Cobra Strike, Claws of Thunder, Phoenix Strike, etc.).
  2. Finisher Release & Discharge Resolution:
    • Full discharge on finisher contact (resolveFinisherDischarge).
    • Single-target & AOE payloads accurately evaluated.
    • Tiger Strike: 3-tier ED% scaling (+1440% at slvl 20 Tier 3).
    • Cobra Strike: Life/Mana steal progression (100% life & 100% mana steal at slvl 20 Tier 3).
    • Claws of Thunder: Cumulative elemental tiers (Tier 3 releases Nova + 4 Charged Bolts).
    • Phoenix Strike: Single targeted tier selection (Tier 1 Meteor, Tier 2 Chain Lightning, Tier 3 Chaos Ice).
  3. Finishers:
    • Dragon Talon: 1 + floor(slvl / 6) multi-kicks, AR scaling 20 + 35 * (slvl - 1)%.
    • Dragon Claw: Dual-claw prerequisite validation, 2 strikes, Claw Mastery ED% synergy.
    • Dragon Tail: Physical-to-fire conversion 50 + 10 * (slvl - 1)%, 6 subtiles (4 yards) AOE explosion, knockback.
    • Dragon Flight: Teleport kick, NextDelay = 4 frames, 100 + 25 * (slvl - 1)% ED.

Test Verification:

  • tests/skills/ass/adv-ass-martial-stress.test.ts: 16/16 passed
  • All 10 Martial Arts unit tests (#254, #255, #259, #260, #265, #269, #270, #274, #275, #280): 30/30 passed (Total: 46/46 passed)
  • TypeScript Typecheck (tsc --noEmit): 0 errors
  • Merged to main via commit 3e85a80 and pushed to origin/main.
### [Milestone M27] Assassin Martial Arts (Charge-ups & Finishers, 10 skills) — COMPLETE & VERIFIED All 10 Assassin Martial Arts skills (#254 Tiger Strike, #255 Dragon Talon, #259 Fists of Fire, #260 Dragon Claw, #265 Cobra Strike, #269 Claws of Thunder, #270 Dragon Tail, #274 Blades of Ice, #275 Dragon Flight, #280 Phoenix Strike) have been implemented and verified with 1.13c parity. #### Implementation Highlights: 1. **ChargeOrbManager**: - 1..3 tier charge accumulation per charge-up skill, capped at 3 charges. - 375-frame (15.0s) duration lifetime with automatic expiration. - Lifetime refreshes upon adding additional charges before timeout. - Multi-skill charge orb coexistence simultaneously (Tiger Strike, Cobra Strike, Claws of Thunder, Phoenix Strike, etc.). 2. **Finisher Release & Discharge Resolution**: - Full discharge on finisher contact (`resolveFinisherDischarge`). - Single-target & AOE payloads accurately evaluated. - Tiger Strike: 3-tier ED% scaling (+1440% at slvl 20 Tier 3). - Cobra Strike: Life/Mana steal progression (100% life & 100% mana steal at slvl 20 Tier 3). - Claws of Thunder: Cumulative elemental tiers (Tier 3 releases Nova + 4 Charged Bolts). - Phoenix Strike: Single targeted tier selection (Tier 1 Meteor, Tier 2 Chain Lightning, Tier 3 Chaos Ice). 3. **Finishers**: - **Dragon Talon**: `1 + floor(slvl / 6)` multi-kicks, AR scaling `20 + 35 * (slvl - 1)%`. - **Dragon Claw**: Dual-claw prerequisite validation, 2 strikes, Claw Mastery ED% synergy. - **Dragon Tail**: Physical-to-fire conversion `50 + 10 * (slvl - 1)%`, 6 subtiles (4 yards) AOE explosion, knockback. - **Dragon Flight**: Teleport kick, NextDelay = 4 frames, `100 + 25 * (slvl - 1)%` ED. #### Test Verification: - `tests/skills/ass/adv-ass-martial-stress.test.ts`: **16/16 passed** - All 10 Martial Arts unit tests (#254, #255, #259, #260, #265, #269, #270, #274, #275, #280): **30/30 passed** (Total: 46/46 passed) - TypeScript Typecheck (`tsc --noEmit`): **0 errors** - Merged to `main` via commit `3e85a80` and pushed to `origin/main`.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: troytt/diablo2-web#474
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?