troytt
/
diablo2-web
1
0
Fork 0
Code Issues 12 Pull Requests Packages Projects Releases Wiki Activity

[Milestone M28] Assassin Shadow Disciplines (10 skills) #475

New Issue
Closed
opened 2026-09-25 03:39:17 +00:00 by troytt · 1 comment
troytt commented 2026-09-25 03:39:17 +00:00
Owner
Copy Link

Milestone M28: Assassin Shadow Disciplines (10 skills)

Implement and verify the complete Assassin Shadow Disciplines skill tree with 1.13c ground truth parity:

  • #252 Claw Mastery
  • #253 Psychic Hammer
  • #258 Burst of Speed (Quickness)
  • #263 Weapon Block
  • #264 Cloak of Shadows
  • #267 Fade
  • #268 Shadow Warrior
  • #269 Claws of Thunder (already in M27) -> #273 Mind Blast
  • #278 Venom
  • #279 Shadow Master

Key Mechanics to Implement:

  1. Burst of Speed vs Fade Mutual Exclusivity:
    • Activating Burst of Speed cancels Fade, and activating Fade cancels Burst of Speed.
    • BoS: IAS% = 20 + floor(slvl*2.5) (or exact 1.13c formula), FRW% = 15 + 3*(slvl-1) + ....
    • Fade: Curse duration reduction %, All Resistances = 15 + 3*(slvl-1) + ..., Hidden Physical Damage Reduction = +1% per slvl.
  2. Venom Bitrate Clamp:
    • 10-frame (0.4s) duration clamp.
    • When combined with other poison sources, Venom forces the poison duration to 10 frames while summing bitrates.
  3. Weapon Block Dual-Claw Mechanics:
    • Only active when dual-wielding claws (twoHanded / dual claw check).
    • Works while standing, casting, or attacking (unlike shield block, does NOT reduce to 1/3 while running in 1.13c, though in classic D2 running block is 0%).
    • Diminishing returns formula for block chance.
  4. Cloak of Shadows:
    • Blinds normal monsters (AI suppression), lowers defense of affected monsters by -X%, boosts Assassin's defense by +Y%.
    • Cannot be recast until the duration expires (or CoS screen effect ends).
  5. Psychic Hammer & Mind Blast:
    • Psychic Hammer: Target-directed physical + magic damage, knockback.
    • Mind Blast: AOE stun, physical damage, and conversion chance (normal/champion/unique resistance).
  6. Shadow Warrior & Shadow Master:
    • Shadow Warrior: Mirrors player's left and right active skills, base stats scaling with slvl.
    • Shadow Master: Autonomous AI, can use any Assassin skill (including skills player hasn't learned), slvl scaling for stats, resists, and random generated equipment based on slvl.
### Milestone M28: Assassin Shadow Disciplines (10 skills) Implement and verify the complete Assassin Shadow Disciplines skill tree with 1.13c ground truth parity: - #252 Claw Mastery - #253 Psychic Hammer - #258 Burst of Speed (Quickness) - #263 Weapon Block - #264 Cloak of Shadows - #267 Fade - #268 Shadow Warrior - #269 Claws of Thunder (already in M27) -> #273 Mind Blast - #278 Venom - #279 Shadow Master #### Key Mechanics to Implement: 1. **Burst of Speed vs Fade Mutual Exclusivity**: - Activating Burst of Speed cancels Fade, and activating Fade cancels Burst of Speed. - BoS: IAS% = `20 + floor(slvl*2.5)` (or exact 1.13c formula), FRW% = `15 + 3*(slvl-1) + ...`. - Fade: Curse duration reduction %, All Resistances = `15 + 3*(slvl-1) + ...`, Hidden Physical Damage Reduction = +1% per slvl. 2. **Venom Bitrate Clamp**: - 10-frame (0.4s) duration clamp. - When combined with other poison sources, Venom forces the poison duration to 10 frames while summing bitrates. 3. **Weapon Block Dual-Claw Mechanics**: - Only active when dual-wielding claws (`twoHanded` / dual claw check). - Works while standing, casting, or attacking (unlike shield block, does NOT reduce to 1/3 while running in 1.13c, though in classic D2 running block is 0%). - Diminishing returns formula for block chance. 4. **Cloak of Shadows**: - Blinds normal monsters (AI suppression), lowers defense of affected monsters by `-X%`, boosts Assassin's defense by `+Y%`. - Cannot be recast until the duration expires (or CoS screen effect ends). 5. **Psychic Hammer & Mind Blast**: - Psychic Hammer: Target-directed physical + magic damage, knockback. - Mind Blast: AOE stun, physical damage, and conversion chance (normal/champion/unique resistance). 6. **Shadow Warrior & Shadow Master**: - Shadow Warrior: Mirrors player's left and right active skills, base stats scaling with slvl. - Shadow Master: Autonomous AI, can use any Assassin skill (including skills player hasn't learned), slvl scaling for stats, resists, and random generated equipment based on slvl.
troytt commented 2026-09-25 03:46:15 +00:00
Author
Owner
Copy Link

[Milestone M28] Assassin Shadow Disciplines (10 skills) — COMPLETE & VERIFIED

All 10 Assassin Shadow Disciplines skills (#252 Claw Mastery, #253 Psychic Hammer, #258 Burst of Speed / Quickness, #263 Weapon Block, #264 Cloak of Shadows, #267 Fade, #268 Shadow Warrior, #273 Mind Blast, #278 Venom, #279 Shadow Master) have been implemented and verified with 1.13c parity.

Implementation Highlights:

  1. Claw Mastery (#252):
    • Attack Rating scaling: 30 + 10 * (slvl - 1)%.
    • Enhanced Damage scaling: 35 + 4 * (slvl - 1)%.
    • Diminishing returns Critical Strike: dm(0, 25, slvl)% (3% at slvl 1, 17% at slvl 10, 21% at slvl 20).
  2. Burst of Speed vs Fade Mutual Exclusivity (#258, #267):
    • ShadowBuffTracker: Applying Burst of Speed immediately cancels Fade; applying Fade immediately cancels Burst of Speed.
    • Burst of Speed: IAS% dm(15, 60, slvl), FRW% dm(15, 70, slvl), duration 3000 + 300 * (slvl - 1) frames.
    • Fade: All Resists dm(10, 75, slvl), Curse Length Reduction dm(40, 90, slvl), hidden Physical Damage Reduction slvl% (+1% per slvl).
    • Venom freely coexists with either Burst of Speed or Fade.
  3. Weapon Block (#263):
    • Strictly enforces dual-claw equipment check (h2h in both weapon slots).
    • Full block chance when standing, walking, attacking, or casting (dm(20, 65, slvl)%).
    • Ground truth invariant: Block drops to strictly 0% while running.
  4. Cloak of Shadows (#264):
    • Duration 200 + 25 * (slvl - 1) frames.
    • Monster defense penalty -min(15 + 3*(slvl-1), 95)% and Assassin defense bonus +(10 + 3*(slvl-1))%.
    • Recast lockout enforced: cannot be recast until active duration has elapsed.
  5. Psychic Hammer & Mind Blast (#253, #273):
    • Psychic Hammer: 50% physical, 50% magic damage; monster-rank knockback scaling (100% normal, dm(50, 100) unique, dm(25, 99) boss/player).
    • Mind Blast: Physical damage, 4-yard AOE stun for 50 + 5 * (slvl - 1) frames, conversion chance dm(15, 40, slvl)%.
    • Conversion immunity: Uniques, SuperUniques, Champions, and Act Bosses are strictly immune to conversion.
  6. Venom Bitrate Clamp Engine (#278):
    • Attack poison duration is clamped strictly to 10 frames (0.4 seconds).
    • Evaluates base poison damage (24..32 at slvl 1, 82..90 at slvl 10, 170..178 at slvl 20).
    • Sums bitrates of all active poison sources and compresses total damage into 10 frames.
  7. Shadow Minion Orchestration (#268, #279):
    • ShadowMinionManager: Global PetType shadowwarrior limit = 1.
    • Summoning Shadow Master dispatches active Shadow Warrior, and vice-versa.
    • Shadow Warrior mirrors player left/right skills at floor(slvl_warrior / 3) + floor(playerSkillLevel / 2).
    • Shadow Master autonomous casting at floor(slvl_master / 2) with equipment quality level scaling 24 + 3 * (slvl - 1).

Test Verification:

  • tests/skills/ass/adv-ass-shadow-stress.test.ts: 21/21 passed
  • All 10 Shadow Disciplines unit tests (#252, #253, #258, #263, #264, #267, #268, #273, #278, #279): 30/30 passed (Total: 51/51 passed)
  • TypeScript Typecheck (tsc --noEmit): 0 errors
  • Merged to main via commit 8d15aac and pushed to origin/main.
### [Milestone M28] Assassin Shadow Disciplines (10 skills) — COMPLETE & VERIFIED All 10 Assassin Shadow Disciplines skills (#252 Claw Mastery, #253 Psychic Hammer, #258 Burst of Speed / Quickness, #263 Weapon Block, #264 Cloak of Shadows, #267 Fade, #268 Shadow Warrior, #273 Mind Blast, #278 Venom, #279 Shadow Master) have been implemented and verified with 1.13c parity. #### Implementation Highlights: 1. **Claw Mastery (#252)**: - Attack Rating scaling: `30 + 10 * (slvl - 1)%`. - Enhanced Damage scaling: `35 + 4 * (slvl - 1)%`. - Diminishing returns Critical Strike: `dm(0, 25, slvl)%` (3% at slvl 1, 17% at slvl 10, 21% at slvl 20). 2. **Burst of Speed vs Fade Mutual Exclusivity (#258, #267)**: - `ShadowBuffTracker`: Applying Burst of Speed immediately cancels Fade; applying Fade immediately cancels Burst of Speed. - Burst of Speed: IAS% `dm(15, 60, slvl)`, FRW% `dm(15, 70, slvl)`, duration `3000 + 300 * (slvl - 1)` frames. - Fade: All Resists `dm(10, 75, slvl)`, Curse Length Reduction `dm(40, 90, slvl)`, hidden Physical Damage Reduction `slvl%` (+1% per slvl). - Venom freely coexists with either Burst of Speed or Fade. 3. **Weapon Block (#263)**: - Strictly enforces dual-claw equipment check (`h2h` in both weapon slots). - Full block chance when standing, walking, attacking, or casting (`dm(20, 65, slvl)%`). - Ground truth invariant: Block drops to strictly **0%** while running. 4. **Cloak of Shadows (#264)**: - Duration `200 + 25 * (slvl - 1)` frames. - Monster defense penalty `-min(15 + 3*(slvl-1), 95)%` and Assassin defense bonus `+(10 + 3*(slvl-1))%`. - Recast lockout enforced: cannot be recast until active duration has elapsed. 5. **Psychic Hammer & Mind Blast (#253, #273)**: - Psychic Hammer: 50% physical, 50% magic damage; monster-rank knockback scaling (100% normal, `dm(50, 100)` unique, `dm(25, 99)` boss/player). - Mind Blast: Physical damage, 4-yard AOE stun for `50 + 5 * (slvl - 1)` frames, conversion chance `dm(15, 40, slvl)%`. - Conversion immunity: Uniques, SuperUniques, Champions, and Act Bosses are strictly immune to conversion. 6. **Venom Bitrate Clamp Engine (#278)**: - Attack poison duration is clamped strictly to 10 frames (0.4 seconds). - Evaluates base poison damage (24..32 at slvl 1, 82..90 at slvl 10, 170..178 at slvl 20). - Sums bitrates of all active poison sources and compresses total damage into 10 frames. 7. **Shadow Minion Orchestration (#268, #279)**: - `ShadowMinionManager`: Global PetType `shadowwarrior` limit = 1. - Summoning Shadow Master dispatches active Shadow Warrior, and vice-versa. - Shadow Warrior mirrors player left/right skills at `floor(slvl_warrior / 3) + floor(playerSkillLevel / 2)`. - Shadow Master autonomous casting at `floor(slvl_master / 2)` with equipment quality level scaling `24 + 3 * (slvl - 1)`. #### Test Verification: - `tests/skills/ass/adv-ass-shadow-stress.test.ts`: **21/21 passed** - All 10 Shadow Disciplines unit tests (#252, #253, #258, #263, #264, #267, #268, #273, #278, #279): **30/30 passed** (Total: 51/51 passed) - TypeScript Typecheck (`tsc --noEmit`): **0 errors** - Merged to `main` via commit `8d15aac` and pushed to `origin/main`.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: troytt/diablo2-web#475
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?