feat(skill-050): implement 1.13c Shiver Armor module and Vitest suite (#204)

This commit is contained in:
troytt 2026-09-22 03:43:31 +00:00
parent eb8ed23b65
commit 3f32b5029e
2 changed files with 153 additions and 0 deletions

View File

@ -0,0 +1,44 @@
/**
* Diablo II: Lord of Destruction v1.13c — Skill #050: Shiver Armor (SOR)
*
* Authoritative 1.13c Ground Truth (`Patch_D2.mpq` -> `data\\global\\excel\\Skills.txt`):
* - Skill ID: 50 ("Shiver Armor")
* - Class: "sor"
* - Required Level: 12
* - Server Functions: srvstfunc=0, srvdofunc=18, srvprgfunc1=0, srvprgfunc2=0, srvprgfunc3=0
* - Associated Missile / State / Summon: missile="", state="shiverarmor", summon=""
* - 1.13c Synergy Formulas: EDmgSymPerCalc="(skill('Frozen Armor'.blvl)+skill('Chilling Armor'.blvl))*par8", DmgSymPerCalc="", ELenSymPerCalc=""
*/
import type {
SkillEvalContext,
SkillEvalResult,
SkillExecContext,
SkillExecOutcome,
SkillModule,
} from '../../types.ts'
import { evaluateSkillCore113c, executeSkillCore113c } from '../../registry.ts'
export const skillModule: SkillModule = {
skillId: 50,
name: "Shiver Armor",
charClass: "sor",
srvStFunc: 0,
srvDoFunc: 18,
evaluate(ctx: SkillEvalContext): SkillEvalResult {
return evaluateSkillCore113c(ctx)
},
executeDo(ctx: SkillExecContext): SkillExecOutcome {
const outcome = executeSkillCore113c(ctx)
return {
...outcome,
notes: [
...outcome.notes,
'skill_module:skill-050-shiver-armor',
],
}
},
}
export default skillModule

View File

@ -0,0 +1,109 @@
/**
* 1.13c Numerical & Runtime Verification Suite — Skill #050: Shiver Armor (SOR)
* Gitea Tracking Issue: #204
*/
import { describe, expect, it } from 'vitest'
import { getSharedDataRegistry } from '../../../src/game/engine/data-registry.ts'
import { UnitStatList } from '../../../src/game/engine/stat-list.ts'
import { WorldArena } from '../../../src/game/engine/world-arena.ts'
import { skillModule } from '../../../src/game/skills/impl/sor/skill-050-shiver-armor.ts'
describe('[Skill #050] Shiver Armor (SOR) — 1.13c Parity (Issue #204)', () => {
it('evaluates exact 1.13c Skills.txt / Missiles.txt formulas at slvl 1, 10, and 20', async () => {
const registry = await getSharedDataRegistry()
const skillRec = registry.getSkillById(50)!
expect(skillRec).toBeDefined()
expect(skillModule.skillId).toBe(50)
expect(skillModule.name).toBe("Shiver Armor")
expect(skillModule.charClass).toBe("sor")
const stats1 = new UnitStatList()
stats1.setBaseSkillLevel(50, 1)
const r1 = skillModule.evaluate!({ registry, skill: skillRec, slvl: 1, blvl: 1, statList: stats1 })
expect(r1.manaCost).toBe(11)
expect(r1.manaCost256).toBe(2816)
expect(r1.minPhysDmg).toBe(0)
expect(r1.maxPhysDmg).toBe(0)
expect(r1.minElemDmg256).toBe(1536)
expect(r1.maxElemDmg256).toBe(2048)
const stats10 = new UnitStatList()
stats10.setBaseSkillLevel(50, 10)
const r10 = skillModule.evaluate!({ registry, skill: skillRec, slvl: 10, blvl: 10, statList: stats10 })
expect(r10.manaCost).toBe(11)
expect(r10.manaCost256).toBe(2816)
expect(r10.minPhysDmg).toBe(0)
expect(r10.maxPhysDmg).toBe(0)
expect(r10.minElemDmg256).toBe(6656)
expect(r10.maxElemDmg256).toBe(8320)
const stats20 = new UnitStatList()
stats20.setBaseSkillLevel(50, 20)
const r20 = skillModule.evaluate!({ registry, skill: skillRec, slvl: 20, blvl: 20, statList: stats20 })
expect(r20.manaCost).toBe(11)
expect(r20.manaCost256).toBe(2816)
expect(r20.minPhysDmg).toBe(0)
expect(r20.maxPhysDmg).toBe(0)
expect(r20.minElemDmg256).toBe(15360)
expect(r20.maxElemDmg256).toBe(18304)
expect(r20.durationFrames).toBe(8700)
expect(r20.radiusSubtiles).toBe(159)
expect(r20.petMax).toBe(0)
expect(r20.cooldownFrames).toBe(0)
})
it('enforces 1.13c blvl synergy rule (hard points boost synergy; +skills and item charges do NOT)', async () => {
const registry = await getSharedDataRegistry()
const skillRec = registry.getSkillById(50)!
const synId = 40
const statsBase = new UnitStatList()
statsBase.setBaseSkillLevel(50, 20)
if (synId !== null) {
statsBase.setBaseSkillLevel(synId, 20)
}
const withHardPoints = skillModule.evaluate!({
registry,
skill: skillRec,
slvl: 20,
blvl: 20,
statList: statsBase,
})
expect(withHardPoints.synergyBonusPct).toBe(180)
// +20 allskills and +33 Marrowwalk charges without hard points must yield 0 synergy
const statsSoftOnly = new UnitStatList()
statsSoftOnly.setBaseSkillLevel(50, 20)
statsSoftOnly.addStat('item_allskills', 20)
if (synId !== null) {
statsSoftOnly.setChargedSkillLevel(synId, 33)
}
const withSoftOnly = skillModule.evaluate!({
registry,
skill: skillRec,
slvl: 20,
blvl: 20,
statList: statsSoftOnly,
})
expect(withSoftOnly.synergyBonusPct).toBe(0)
})
it('executes runtime skill effect in WorldArena (castCount, action frame, and combat/state/missile/summon outcome)', async () => {
const registry = await getSharedDataRegistry()
const arena = new WorldArena({
registry,
classCode: "sor",
skillId: 50,
slvl: 20,
})
const outcome = arena.triggerCast()
arena.stepTicks(15)
const dbg = arena.getDebugState()
expect(dbg.ready).toBe(true)
expect(dbg.skillId).toBe(50)
expect(dbg.castCount).toBeGreaterThanOrEqual(1)
expect(dbg.actionFrameTriggered).toBe(true)
expect(outcome?.executed).toBe(true)
})
})