[Skill #217] [UNI] Scroll of Identify (1.13c Parity) #310
Labels
No Label
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: troytt/diablo2-web#310
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Diablo II: Lord of Destruction v1.13c Skill Parity Specification
217(#217)skilldesc: scroll of identify)uni(Universal / Item-Granted)reqlevel)1reqskill1..3)-,-,-src/game/skills/impl/uni/skill-217-scroll-of-identify.tstests/skills/uni/skill-217-scroll-of-identify.test.ts1. Authoritative 1.13c
Skills.txtFunction & Handler Dispatchsrvstfunc(Server Start / Pre-Cast)-srvdofunc(Server Action Frame0x01/0x02)113srvprgfunc1..3(Progressive Charge Release)-/-/-cltstfunc/cltdofunc(Client Start / Action)-/-cltprgfunc1..3(Client Progressive Release)-/-/-passive/checkfuncpassive=-/checkfunc=5auraevent1/auraeventfunc1-/-2. Associated Missiles, States, Auras, Curses & Summons
srvmissile/a..c)-/a:-,b:-,c:-cltmissile/cltmissilea)-/-aurastate/auratgtstate)self:-/tgt:-aurastat1..3)-,-,-passivestate/passivestat1..3)state:-/-,-,-cursetype)-summon/pettype/petmax)mon:-/type:-/max:-3. 1.13c Base Numerical & Synergy Formulas (
Patch_D2.mpq)mana=-,lvlmana=-(256-fixed-point<< HitShift)MinDam=-,MaxDam=-,EType=-,EMin=-,EMax=-,ELen=-calc1..4:calc1=-,calc2=-,calc3=-,calc4=-blvlstrictly base allocatedSTAT_SKILLPTSonly):EDmgSymPerCalc:-DmgSymPerCalc:-ELenSymPerCalc:-4. R3 Verification & Merge Checklist
git worktree add ../wt-skill-217 -b feat/skill-217frommain.src/game/skills/impl/uni/skill-217-scroll-of-identify.tsimplements exact 1.13csrvstfunc/srvdofunc/srvprgfunc& numerical evaluation.slvl1, 10, 20 +blvlSynergies):tests/skills/uni/skill-217-scroll-of-identify.test.tspasses 100% in Vitest verifyingManaCost,MinDmg,MaxDmg,ToHit,Duration,Radius, synergy scaling, and runtime combat/missile/state/summon effect.acts.html?arena=1&class=uni&skill=217&slvl=20&autocast=1) with zero console/page errors and PNG screenshot attached to this Issue.mainwithfixes #<issue_number>, pushed toorigin/main, verified Issue isclosed, and removed worktree../wt-skill-217+ branchfeat/skill-217.✅ Completed: [Skill #217] Scroll of Identify (
UNI) — 1.13c Parity Verified1. Isolated Worktree & Module Implementation
../wt-skill-217(feat/skill-217)src/game/skills/impl/uni/skill-217-scroll-of-identify.tstests/skills/uni/skill-217-scroll-of-identify.test.tssrvstfunc=0,srvdofunc=113,missile=none,state=none,summon=none2. 1.13c Numerical & Synergy Verification Table
slvl = 1slvl = 10slvl = 20(0 Syn)slvl = 20(+20blvlSyn)usmc)0(0)0(0)0(0)0(0)Min-Max)0-00-00-00-0Min-Max)0-0(mag)0-0(mag)0-0(mag)0-0(+0%)+0%/0f/0+0%/0f/0+0%/0f/0+0%/0f/03. Headless Chromium (
chromium-1228) Runtime Telemetry & Screenshotready=true,classCode=uni(so),castCount=1,anim=SC:7,totalDamageDealt=0,consoleErrors=0586786bytesCohort 8 Universal Skills 1.13c Parity Verification — Skill #217 (
Scroll of Identify)D2MOO C++ Ground Truth References
SKILLS_SrvDo113_Scroll_Book(D2Game/src/SKILLS/SkillItem.cpp:898)SKILLITEM_pSpell01_IdentifyItem(D2Game/src/SKILLS/SkillItem.cpp:65)D2GAME_ITEMS_Identify_6FC49670(D2Game/src/ITEMS/ItemMode.cpp:4532)1.13c Parity Verification Summary
inTown = trueallowance, target itemIFLAG_IDENTIFIEDvalidation & identification (identified = true), and 1 scroll consumption.npx vitest run tests/skills/universal/universal-skills.test.ts— 100% PASS.