[Skill #063] [SOR] Lightning Mastery (1.13c Parity) #217

Closed
opened 2026-09-22 02:40:07 +00:00 by troytt · 2 comments
Owner

Diablo II: Lord of Destruction v1.13c Skill Parity Specification

Field Value
Skill ID 63 (#063)
Skill Name Lightning Mastery (skilldesc: lightning mastery)
Class sor (Sorceress)
Required Level (reqlevel) 30
Prerequisites (reqskill1..3) -, -, -
Isolated Implementation Module src/game/skills/impl/sor/skill-063-lightning-mastery.ts
Isolated Vitest Suite tests/skills/sor/skill-063-lightning-mastery.test.ts

1. Authoritative 1.13c Skills.txt Function & Handler Dispatch

Function Slot 1.13c Value
srvstfunc (Server Start / Pre-Cast) -
srvdofunc (Server Action Frame 0x01/0x02) -
srvprgfunc1..3 (Progressive Charge Release) - / - / -
cltstfunc / cltdofunc (Client Start / Action) - / -
cltprgfunc1..3 (Client Progressive Release) - / - / -
passive / checkfunc passive=1 / checkfunc=-
auraevent1 / auraeventfunc1 - / -

2. Associated Missiles, States, Auras, Curses & Summons

Subsystem 1.13c Configuration
Server Missiles (srvmissile / a..c) - / a:-, b:-, c:-
Client Missiles (cltmissile / cltmissilea) - / -
Aura / Buff States (aurastate / auratgtstate) self:- / tgt:-
Aura / Buff Stats (aurastat1..3) -, -, -
Passive State & Stats (passivestate / passivestat1..3) state:lightningmastery / passive_ltng_mastery, -, -
Curse Priority (cursetype) -
Summon / Pet (summon / pettype / petmax) mon:- / type:- / max:-

3. 1.13c Base Numerical & Synergy Formulas (Patch_D2.mpq)

  • Mana Cost: mana=0, lvlmana=0 (256-fixed-point << HitShift)
  • Physical / Elemental Damage: MinDam=-, MaxDam=-, EType=-, EMin=-, EMax=-, ELen=-
  • AST calc1..4: calc1=-, calc2=-, calc3=-, calc4=-
  • Synergy Calculations (blvl strictly base allocated STAT_SKILLPTS only):
    • EDmgSymPerCalc: -
    • DmgSymPerCalc: -
    • ELenSymPerCalc: -

4. R3 Verification & Merge Checklist

  • Isolated Git Worktree: Created via git worktree add ../wt-skill-63 -b feat/skill-63 from main.
  • 1.13c Implementation: src/game/skills/impl/sor/skill-063-lightning-mastery.ts implements exact 1.13c srvstfunc/srvdofunc/srvprgfunc & numerical evaluation.
  • Automated Unit & Numerical Tests (slvl 1, 10, 20 + blvl Synergies): tests/skills/sor/skill-063-lightning-mastery.test.ts passes 100% in Vitest verifying ManaCost, MinDmg, MaxDmg, ToHit, Duration, Radius, synergy scaling, and runtime combat/missile/state/summon effect.
  • Real-Browser Casting & Screenshot: Executed in headless Chromium (acts.html?arena=1&class=sor&skill=63&slvl=20&autocast=1) with zero console/page errors and PNG screenshot attached to this Issue.
  • Merge & Cleanup: Merged to main with fixes #<issue_number>, pushed to origin/main, verified Issue is closed, and removed worktree ../wt-skill-63 + branch feat/skill-63.
## Diablo II: Lord of Destruction v1.13c Skill Parity Specification | Field | Value | |---|---| | **Skill ID** | `63` (`#063`) | | **Skill Name** | **Lightning Mastery** (`skilldesc: lightning mastery`) | | **Class** | `sor` (Sorceress) | | **Required Level (`reqlevel`)** | `30` | | **Prerequisites (`reqskill1..3`)** | `-`, `-`, `-` | | **Isolated Implementation Module** | `src/game/skills/impl/sor/skill-063-lightning-mastery.ts` | | **Isolated Vitest Suite** | `tests/skills/sor/skill-063-lightning-mastery.test.ts` | --- ### 1. Authoritative 1.13c `Skills.txt` Function & Handler Dispatch | Function Slot | 1.13c Value | |---|---| | **`srvstfunc`** (Server Start / Pre-Cast) | `-` | | **`srvdofunc`** (Server Action Frame `0x01`/`0x02`) | `-` | | **`srvprgfunc1..3`** (Progressive Charge Release) | `-` / `-` / `-` | | **`cltstfunc` / `cltdofunc`** (Client Start / Action) | `-` / `-` | | **`cltprgfunc1..3`** (Client Progressive Release) | `-` / `-` / `-` | | **`passive` / `checkfunc`** | `passive=1` / `checkfunc=-` | | **`auraevent1` / `auraeventfunc1`** | `-` / `-` | ### 2. Associated Missiles, States, Auras, Curses & Summons | Subsystem | 1.13c Configuration | |---|---| | **Server Missiles (`srvmissile` / `a..c`)** | `-` / `a:-`, `b:-`, `c:-` | | **Client Missiles (`cltmissile` / `cltmissilea`)** | `-` / `-` | | **Aura / Buff States (`aurastate` / `auratgtstate`)** | `self:-` / `tgt:-` | | **Aura / Buff Stats (`aurastat1..3`)** | `-`, `-`, `-` | | **Passive State & Stats (`passivestate` / `passivestat1..3`)** | `state:lightningmastery` / `passive_ltng_mastery`, `-`, `-` | | **Curse Priority (`cursetype`)** | `-` | | **Summon / Pet (`summon` / `pettype` / `petmax`)** | `mon:-` / `type:-` / `max:-` | ### 3. 1.13c Base Numerical & Synergy Formulas (`Patch_D2.mpq`) - **Mana Cost**: `mana=0`, `lvlmana=0` (256-fixed-point `<< HitShift`) - **Physical / Elemental Damage**: `MinDam=-`, `MaxDam=-`, `EType=-`, `EMin=-`, `EMax=-`, `ELen=-` - **AST `calc1..4`**: `calc1=-`, `calc2=-`, `calc3=-`, `calc4=-` - **Synergy Calculations (`blvl` strictly base allocated `STAT_SKILLPTS` only)**: - `EDmgSymPerCalc`: `-` - `DmgSymPerCalc`: `-` - `ELenSymPerCalc`: `-` --- ### 4. R3 Verification & Merge Checklist - [ ] **Isolated Git Worktree**: Created via `git worktree add ../wt-skill-63 -b feat/skill-63` from `main`. - [ ] **1.13c Implementation**: `src/game/skills/impl/sor/skill-063-lightning-mastery.ts` implements exact 1.13c `srvstfunc`/`srvdofunc`/`srvprgfunc` & numerical evaluation. - [ ] **Automated Unit & Numerical Tests (`slvl` 1, 10, 20 + `blvl` Synergies)**: `tests/skills/sor/skill-063-lightning-mastery.test.ts` passes 100% in Vitest verifying `ManaCost`, `MinDmg`, `MaxDmg`, `ToHit`, `Duration`, `Radius`, synergy scaling, and runtime combat/missile/state/summon effect. - [ ] **Real-Browser Casting & Screenshot**: Executed in headless Chromium (`acts.html?arena=1&class=sor&skill=63&slvl=20&autocast=1`) with zero console/page errors and PNG screenshot attached to this Issue. - [ ] **Merge & Cleanup**: Merged to `main` with `fixes #<issue_number>`, pushed to `origin/main`, verified Issue is `closed`, and removed worktree `../wt-skill-63` + branch `feat/skill-63`.
troytt added this to the All Player Skills (v1.13c Parity) milestone 2026-09-22 02:40:07 +00:00
Author
Owner

✅ Completed: [Skill #063] Lightning Mastery (SOR) — 1.13c Parity Verified

1. Isolated Worktree & Module Implementation

  • Worktree & Branch: ../wt-skill-063 (feat/skill-063)
  • Skill Module: src/game/skills/impl/sor/skill-063-lightning-mastery.ts
  • Vitest Suite: tests/skills/sor/skill-063-lightning-mastery.test.ts
  • 1.13c Dispatch: srvstfunc=0, srvdofunc=0, missile=none, state=lightningmastery, summon=none

2. 1.13c Numerical & Synergy Verification Table

Metric slvl = 1 slvl = 10 slvl = 20 (0 Syn) slvl = 20 (+20 blvl Syn)
Mana Cost (usmc) 0 (0) 0 (0) 0 (0) 0 (0)
Phys Dmg (Min-Max) 0-0 0-0 0-0 0-0
Elem Dmg (Min-Max) 0-0 (mag) 0-0 (mag) 0-0 (mag) 0-0 (+0%)
AR % / Duration / Radius +0% / 0f / 50 +0% / 0f / 158 +0% / 0f / 278 +0% / 0f / 278

3. Headless Chromium (chromium-1228) Runtime Telemetry & Screenshot

  • Arena State: ready=true, classCode=sor (so), castCount=1, anim=SC:6, totalDamageDealt=0, consoleErrors=0
  • Captured PNG Size: 586980 bytes

Skill #063 Lightning Mastery

### ✅ Completed: [Skill #063] Lightning Mastery (`SOR`) — 1.13c Parity Verified #### 1. Isolated Worktree & Module Implementation - **Worktree & Branch**: `../wt-skill-063` (`feat/skill-063`) - **Skill Module**: `src/game/skills/impl/sor/skill-063-lightning-mastery.ts` - **Vitest Suite**: `tests/skills/sor/skill-063-lightning-mastery.test.ts` - **1.13c Dispatch**: `srvstfunc=0`, `srvdofunc=0`, `missile=none`, `state=lightningmastery`, `summon=none` #### 2. 1.13c Numerical & Synergy Verification Table | Metric | `slvl = 1` | `slvl = 10` | `slvl = 20` (0 Syn) | `slvl = 20` (+20 `blvl` Syn) | | :--- | :---: | :---: | :---: | :---: | | **Mana Cost (`usmc`)** | `0` (`0`) | `0` (`0`) | `0` (`0`) | `0` (`0`) | | **Phys Dmg (`Min-Max`)** | `0-0` | `0-0` | `0-0` | `0-0` | | **Elem Dmg (`Min-Max`)** | `0-0` (`mag`) | `0-0` (`mag`) | `0-0` (`mag`) | `0-0` (+0%) | | **AR % / Duration / Radius** | `+0%` / `0f` / `50` | `+0%` / `0f` / `158` | `+0%` / `0f` / `278` | `+0%` / `0f` / `278` | #### 3. Headless Chromium (`chromium-1228`) Runtime Telemetry & Screenshot - **Arena State**: `ready=true`, `classCode=sor` (`so`), `castCount=1`, `anim=SC:6`, `totalDamageDealt=0`, `consoleErrors=0` - **Captured PNG Size**: `586980` bytes ![Skill #063 Lightning Mastery](https://git.projectdiablo2.cn/attachments/8b4c7145-6512-4d86-b30e-f0da526a2838)
Author
Owner

Milestone M4 Complete: Lightning Mastery (63) 1.13c Ground-Truth Parity Verified

  • Commit: a0567c2 (merged to main)
  • Test Suite: tests/skills/sor/skill-063-lightning-mastery.test.ts (17/17 tests passing)
  • 7-Dimensional Parity Details:
    • D1: Skills.txt row 63 parsing (passive 1, passivestate lightningmastery, Param1=50, Param2=12, reqlevel 30).
    • D2: Zero active costs (mana 0, cooldown 0, no missile, calculateSkillDamage returns {min: 0, max: 0}).
    • D3: Authentic 1.13c formula: 50 + (slvl - 1) * 12 percent (lvl 1=50%, lvl 2=62%, lvl 10=158%, lvl 20=278%, lvl 40=518%). Safe clamping for non-positive slvl to 0%.
    • D4: Multiplicative synergy scaling across all 5 lightning skills (Charged Bolt, Lightning, Chain Lightning, Nova, Thunder Storm): Final = Math.floor(Base * (1 + Syn/100) * (1 + Mastery/100)).
    • D5: StatList integration: getAccruedStat("passive_ltng_mastery") and getAccruedStat("passive_lightning_mastery") automatically query effective level including +skills items. Integrated into combat pipeline executeSUnitDmg.
    • D6: Edge cases: non-lightning elemental isolation (fire, cold, physical unaffected), zero synergies received.
    • D7: BATCH1_SKILLS length invariant strictly 38, zero runtime MPQ queries.
### Milestone M4 Complete: Lightning Mastery (63) 1.13c Ground-Truth Parity Verified - **Commit**: `a0567c2` (merged to `main`) - **Test Suite**: `tests/skills/sor/skill-063-lightning-mastery.test.ts` (17/17 tests passing) - **7-Dimensional Parity Details**: - D1: Skills.txt row 63 parsing (passive 1, passivestate lightningmastery, Param1=50, Param2=12, reqlevel 30). - D2: Zero active costs (mana 0, cooldown 0, no missile, calculateSkillDamage returns {min: 0, max: 0}). - D3: Authentic 1.13c formula: `50 + (slvl - 1) * 12` percent (lvl 1=50%, lvl 2=62%, lvl 10=158%, lvl 20=278%, lvl 40=518%). Safe clamping for non-positive slvl to 0%. - D4: Multiplicative synergy scaling across all 5 lightning skills (Charged Bolt, Lightning, Chain Lightning, Nova, Thunder Storm): `Final = Math.floor(Base * (1 + Syn/100) * (1 + Mastery/100))`. - D5: StatList integration: `getAccruedStat("passive_ltng_mastery")` and `getAccruedStat("passive_lightning_mastery")` automatically query effective level including `+skills` items. Integrated into combat pipeline `executeSUnitDmg`. - D6: Edge cases: non-lightning elemental isolation (fire, cold, physical unaffected), zero synergies received. - D7: `BATCH1_SKILLS` length invariant strictly 38, zero runtime MPQ queries.
Sign in to join this conversation.
No Label
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: troytt/diablo2-web#217
No description provided.