troytt
/
diablo2-web
1
0
Fork 0
Code Issues 12 Pull Requests Packages Projects Releases Wiki Activity

[Milestone M17] Barbarian Combat Skills (Bash, Leap, Double Swing, Stun, Double Throw, Leap Attack, Concentrate, Frenzy, Whirlwind, Berserk) #464

New Issue
Closed
opened 2026-09-25 01:49:42 +00:00 by troytt · 1 comment
troytt commented 2026-09-25 01:49:42 +00:00
Owner
Copy Link

Milestone M17: Barbarian Combat Skills Specification

Target Skills (10 skills):

  1. Bash (126): Knockback attack, +50% + 5%/lvl dmg, flat +1 +1/lvl min/max phys dmg, synergies from Stun (+5%/pt) and Concentrate (+5%/pt).
  2. Leap (132): Distance leap with landing knockback wave, radius = 4 + 1/lvl subtiles, synergy from Leap Attack (+10%/pt).
  3. Double Swing (133): Dual weapon rapid swing, decreasing mana cost (2 base down to 0 at lvl 9+), synergy from Bash (+10%/pt).
  4. Stun (139): Stun hit with duration 30 + 5/lvl frames, Stun overlay, synergies from Bash (+8%/pt), War Cry (+5% len/pt), Concentrate (+5%/pt).
  5. Double Throw (140): Dual throwing weapons barrage, synergy from Double Swing (+8%/pt).
  6. Leap Attack (143): High damage targeted leap, +100% + 30%/lvl dmg, knockback radius 4 + 2/lvl, synergy from Leap (+10%/pt).
  7. Concentrate (144): Uninterruptible attack with +100% + 10%/lvl defense bonus and +70% + 5%/lvl dmg, synergies from Bash (+5%/pt), Battle Orders (+10%/pt), Berserk (+1% magic/pt).
  8. Frenzy (147): Dual attack stacking Frenzy buff (speed & attack rate, duration 150 frames), Frenzy overlay, synergies from Double Swing (+8%/pt), Taunt (+8%/pt), Berserk (+1% magic/pt).
  9. Whirlwind (151): Continuous spinning path attack, -50% + 8%/lvl dmg, fixed hit rate.
  10. Berserk (152): 100% physical-to-magic conversion attack, +150% + 15%/lvl dmg, temporary 0 defense state with Berserk overlay, synergies from Howl (+10%/pt) and Shout (+10%/pt).

Requirements:

  • Strict worktree isolation (.worktrees/barbarian-combat)
  • Dedicated calculation module in src/game/skills/barbarian-combat.ts
  • Full per-skill impl integration in src/game/skills/impl/bar/
  • Adversarial test suite in tests/skills/bar/adv-bar-combat-stress.test.ts
  • Maintain BATCH1_SKILLS length = 38
  • Zero typecheck errors, 0 regressions
## Milestone M17: Barbarian Combat Skills Specification ### Target Skills (10 skills): 1. **Bash (126)**: Knockback attack, +50% + 5%/lvl dmg, flat +1 +1/lvl min/max phys dmg, synergies from Stun (+5%/pt) and Concentrate (+5%/pt). 2. **Leap (132)**: Distance leap with landing knockback wave, radius = 4 + 1/lvl subtiles, synergy from Leap Attack (+10%/pt). 3. **Double Swing (133)**: Dual weapon rapid swing, decreasing mana cost (2 base down to 0 at lvl 9+), synergy from Bash (+10%/pt). 4. **Stun (139)**: Stun hit with duration 30 + 5/lvl frames, Stun overlay, synergies from Bash (+8%/pt), War Cry (+5% len/pt), Concentrate (+5%/pt). 5. **Double Throw (140)**: Dual throwing weapons barrage, synergy from Double Swing (+8%/pt). 6. **Leap Attack (143)**: High damage targeted leap, +100% + 30%/lvl dmg, knockback radius 4 + 2/lvl, synergy from Leap (+10%/pt). 7. **Concentrate (144)**: Uninterruptible attack with +100% + 10%/lvl defense bonus and +70% + 5%/lvl dmg, synergies from Bash (+5%/pt), Battle Orders (+10%/pt), Berserk (+1% magic/pt). 8. **Frenzy (147)**: Dual attack stacking Frenzy buff (speed & attack rate, duration 150 frames), Frenzy overlay, synergies from Double Swing (+8%/pt), Taunt (+8%/pt), Berserk (+1% magic/pt). 9. **Whirlwind (151)**: Continuous spinning path attack, -50% + 8%/lvl dmg, fixed hit rate. 10. **Berserk (152)**: 100% physical-to-magic conversion attack, +150% + 15%/lvl dmg, temporary 0 defense state with Berserk overlay, synergies from Howl (+10%/pt) and Shout (+10%/pt). ### Requirements: - Strict worktree isolation (.worktrees/barbarian-combat) - Dedicated calculation module in src/game/skills/barbarian-combat.ts - Full per-skill impl integration in src/game/skills/impl/bar/ - Adversarial test suite in tests/skills/bar/adv-bar-combat-stress.test.ts - Maintain BATCH1_SKILLS length = 38 - Zero typecheck errors, 0 regressions
troytt commented 2026-09-25 01:57:30 +00:00
Author
Owner
Copy Link

Milestone M17: Barbarian Combat Skills — Verification & Landed Evidence

All 10 Barbarian Combat Skills have been implemented, strictly verified against Diablo II v1.13c ground truth, and merged to main in commit bd4920f.

Implemented Skills

  1. Bash (126): Exact damage %, flat physical damage (+1 at slvl 1, +10 at slvl 10, +20 at slvl 20), knockback, synergy (+5% dmg / blvl in Stun).
  2. Leap (132): Distance scaling (4-8 to 4-15.6 yards), knockback radius (4.6 to 14.6 subtiles), mana 2.
  3. Double Swing (133): Attack rate bonus, dual-wield requirement, decreasing mana cost (starts at 2 mana, drops by 0.25/lvl, reaches 0 mana at slvl 9+), synergy (+10% dmg / blvl in Bash).
  4. Stun (139): Base stun duration (30 frames + 5/lvl), synergies (+8% dmg from Bash, +5% duration from War Cry).
  5. Double Throw (140): Dual-wield thrown weapon requirements and AR progression (+10% + 5%/lvl).
  6. Leap Attack (143): Massive damage scaling (+100% + 30%/lvl), knockback radius (4.6 to 14.6 subtiles).
  7. Concentrate (144): Defense bonus (+100% + 10%/lvl), uninterruptible attack flag, synergies (+5% dmg from Bash, +10% dmg from Battle Orders, +1% magic dmg from Berserk).
  8. Frenzy (147): Move speed & attack speed progression, 150 frames (6s) buff duration, synergies (+8% dmg from Double Swing and Taunt, +1% magic dmg from Berserk).
  9. Whirlwind (151): Authentic 1.13c negative scaling (-50% at slvl 1, +8%/lvl, +102% at slvl 20), hit frequency 4 frames.
  10. Berserk (152): 100% physical to magic damage conversion, zero-defense duration reduction formula (par4 - min(((110*lvl)/(lvl+6)*(par4-par3)/100),(par4-par3))), synergies (+10% magic dmg from Howl and Shout).

Quality Gate Verification Results

  • tests/skills/bar/adv-bar-combat-stress.test.ts: 20/20 tests passed
  • tests/skills/bar/: 33 test files, 124/124 tests passed
  • Full test suite: 0 regressions
  • npm run typecheck: 0 errors
  • Invariant: BATCH1_SKILLS length strictly = 38
### Milestone M17: Barbarian Combat Skills — Verification & Landed Evidence All 10 Barbarian Combat Skills have been implemented, strictly verified against Diablo II v1.13c ground truth, and merged to `main` in commit `bd4920f`. #### Implemented Skills 1. **Bash (126)**: Exact damage %, flat physical damage (+1 at slvl 1, +10 at slvl 10, +20 at slvl 20), knockback, synergy (+5% dmg / blvl in Stun). 2. **Leap (132)**: Distance scaling (4-8 to 4-15.6 yards), knockback radius (4.6 to 14.6 subtiles), mana 2. 3. **Double Swing (133)**: Attack rate bonus, dual-wield requirement, decreasing mana cost (starts at 2 mana, drops by 0.25/lvl, reaches 0 mana at slvl 9+), synergy (+10% dmg / blvl in Bash). 4. **Stun (139)**: Base stun duration (30 frames + 5/lvl), synergies (+8% dmg from Bash, +5% duration from War Cry). 5. **Double Throw (140)**: Dual-wield thrown weapon requirements and AR progression (+10% + 5%/lvl). 6. **Leap Attack (143)**: Massive damage scaling (+100% + 30%/lvl), knockback radius (4.6 to 14.6 subtiles). 7. **Concentrate (144)**: Defense bonus (+100% + 10%/lvl), uninterruptible attack flag, synergies (+5% dmg from Bash, +10% dmg from Battle Orders, +1% magic dmg from Berserk). 8. **Frenzy (147)**: Move speed & attack speed progression, 150 frames (6s) buff duration, synergies (+8% dmg from Double Swing and Taunt, +1% magic dmg from Berserk). 9. **Whirlwind (151)**: Authentic 1.13c negative scaling (-50% at slvl 1, +8%/lvl, +102% at slvl 20), hit frequency 4 frames. 10. **Berserk (152)**: 100% physical to magic damage conversion, zero-defense duration reduction formula (`par4 - min(((110*lvl)/(lvl+6)*(par4-par3)/100),(par4-par3))`), synergies (+10% magic dmg from Howl and Shout). #### Quality Gate Verification Results - `tests/skills/bar/adv-bar-combat-stress.test.ts`: 20/20 tests passed - `tests/skills/bar/`: 33 test files, 124/124 tests passed - Full test suite: 0 regressions - `npm run typecheck`: 0 errors - Invariant: `BATCH1_SKILLS` length strictly = 38
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: troytt/diablo2-web#464
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?