troytt
/
diablo2-web
1
0
Fork 0
Code Issues 12 Pull Requests Packages Projects Releases Wiki Activity

[Milestone M29] Assassin Class Gate & End-to-End Suite (30/30 skills) #476

New Issue
Closed
opened 2026-09-25 03:46:34 +00:00 by troytt · 1 comment
troytt commented 2026-09-25 03:46:34 +00:00
Owner
Copy Link

Milestone M29: Assassin Class Gate & End-to-End Suite (30/30 skills)

Comprehensive class-level integration and end-to-end verification gate for all 30 Assassin skills across all 3 skill trees (Traps, Martial Arts, Shadow Disciplines) with 1.13c ground truth parity:

  • Traps (10 skills): Fire Blast (#251), Shock Web (#256), Blade Sentinel (#257), Charged Bolt Sentry (#261), Wake of Fire (#262), Blade Fury (#266), Lightning Sentry (#271), Wake of Inferno (#272), Death Sentry (#276), Blade Shield (#277).
  • Martial Arts (10 skills): Tiger Strike (#254), Dragon Talon (#255), Fists of Fire (#259), Dragon Claw (#260), Cobra Strike (#265), Claws of Thunder (#269), Dragon Tail (#270), Blades of Ice (#274), Dragon Flight (#275), Phoenix Strike (#280).
  • Shadow Disciplines (10 skills): Claw Mastery (#252), Psychic Hammer (#253), Burst of Speed (#258), Weapon Block (#263), Cloak of Shadows (#264), Fade (#267), Shadow Warrior (#268), Mind Blast (#273), Venom (#278), Shadow Master (#279).

Verification Scope:

  1. Complete 30-skill tree matrix evaluation and hard-point synergy cross-validation.
  2. Cross-tree build runtime integration (e.g. Trapper with BoS/Fade + Shadow Master; Kicker/Finisher with Death Sentry).
  3. Summons & PetType limits: 5 Traps (assassintrap) + 1 Shadow (shadowwarrior) concurrent ceiling.
  4. NextDelay collision avoidance across Wake of Fire, Shock Web, Dragon Flight, and Blade Sentinel.
  5. All 30 unit tests + 3 adversarial stress suites + E2E class gate.
### Milestone M29: Assassin Class Gate & End-to-End Suite (30/30 skills) Comprehensive class-level integration and end-to-end verification gate for all 30 Assassin skills across all 3 skill trees (Traps, Martial Arts, Shadow Disciplines) with 1.13c ground truth parity: - **Traps (10 skills)**: Fire Blast (#251), Shock Web (#256), Blade Sentinel (#257), Charged Bolt Sentry (#261), Wake of Fire (#262), Blade Fury (#266), Lightning Sentry (#271), Wake of Inferno (#272), Death Sentry (#276), Blade Shield (#277). - **Martial Arts (10 skills)**: Tiger Strike (#254), Dragon Talon (#255), Fists of Fire (#259), Dragon Claw (#260), Cobra Strike (#265), Claws of Thunder (#269), Dragon Tail (#270), Blades of Ice (#274), Dragon Flight (#275), Phoenix Strike (#280). - **Shadow Disciplines (10 skills)**: Claw Mastery (#252), Psychic Hammer (#253), Burst of Speed (#258), Weapon Block (#263), Cloak of Shadows (#264), Fade (#267), Shadow Warrior (#268), Mind Blast (#273), Venom (#278), Shadow Master (#279). #### Verification Scope: 1. Complete 30-skill tree matrix evaluation and hard-point synergy cross-validation. 2. Cross-tree build runtime integration (e.g. Trapper with BoS/Fade + Shadow Master; Kicker/Finisher with Death Sentry). 3. Summons & PetType limits: 5 Traps (assassintrap) + 1 Shadow (shadowwarrior) concurrent ceiling. 4. NextDelay collision avoidance across Wake of Fire, Shock Web, Dragon Flight, and Blade Sentinel. 5. All 30 unit tests + 3 adversarial stress suites + E2E class gate.
troytt commented 2026-09-25 03:52:42 +00:00
Author
Owner
Copy Link

[Milestone M29] Assassin Class Gate & End-to-End Suite (30/30 skills) — COMPLETE & VERIFIED

The comprehensive class-level integration and end-to-end verification gate for all 30 Assassin skills across all 3 skill trees (Traps, Martial Arts, Shadow Disciplines) has passed with 1.13c ground truth parity.

Test Coverage & Verification:

  • tests/skills/ass/adv-ass-e2e-gate.test.ts (17/17 passed):
    1. Scenario 1: Traps Tree Synergy Network & 5-Band Progression:
      • Lightning Sentry: 5-band scaling (base max 314) and +720% synergy (Shock Web, CBS, DS) scaling up to 2574 max damage.
      • Death Sentry: Corpse explosion radius (10 + slvl - 1 subtiles), shot count scaling with Fire Blast hard points, 40-80% corpse HP explosion.
      • Blade weapon scaling: Blade Sentinel (3/8), Blade Fury (3/4).
    2. Scenario 2: Martial Arts Charge-Up & Finisher Discharge Pipeline:
      • Multi-skill charge accumulation (Tiger + Cobra + Phoenix).
      • Full finisher discharge on contact releasing all active charges.
      • Phoenix Strike single-tier payload selection (Meteor, Chain Lightning, Chaos Ice).
      • Dragon Talon multi-kicks (1 + floor(slvl/6)) and Dragon Claw dual-claw strike mechanics.
    3. Scenario 3: Shadow Disciplines Buff Mechanics & Venom Bitrate Clamp:
      • Strict mutual exclusivity between Burst of Speed and Fade.
      • Venom 10-frame duration clamp and bitrate summing with weapon poison.
      • Cloak of Shadows recast lockout and defense debuff/buff.
    4. Scenario 4: Minion & Summon Caps:
      • Global 5-trap FIFO eviction cap on assassintrap PetType.
      • PetType shadowwarrior cap = 1 with mutual replacement between Warrior and Master.
      • Full coexistence: 5 Traps + 1 Shadow Master = 6 concurrent pets.
    5. Scenario 5: NextDelay Collision Avoidance Across Trees:
      • NextDelay hit protection (Wake of Fire 4f, Shock Web 25f, Dragon Flight 4f).
    6. Scenario 6: Cross-Tree Hybrid Build Integration:
      • Trapper / Kicksin / Shadow Master combined combat loop without state corruption.
    7. Scenario 7: Crowd Control & Status Effects:
      • Mind Blast 4-yard AOE stun & conversion chance with boss/unique immunity.
      • Psychic Hammer 50/50 magic/phys damage and knockback scaling.
    8. Scenario 8: Complete 30-Skill Registry & Architectural Invariants:
      • All 30 skills (IDs 251..280) exist in D2DataRegistry with charClass: "ass".
      • BATCH1_SKILLS length invariant strictly maintained at 38.

Overall Test Results:

  • All 34 Assassin test files passed: 166/166 tests passed
  • TypeScript Typecheck (tsc --noEmit): 0 errors
  • Merged to main via commit a70ab93 and pushed to origin/main.
### [Milestone M29] Assassin Class Gate & End-to-End Suite (30/30 skills) — COMPLETE & VERIFIED The comprehensive class-level integration and end-to-end verification gate for all 30 Assassin skills across all 3 skill trees (Traps, Martial Arts, Shadow Disciplines) has passed with 1.13c ground truth parity. #### Test Coverage & Verification: - **`tests/skills/ass/adv-ass-e2e-gate.test.ts` (17/17 passed)**: 1. *Scenario 1: Traps Tree Synergy Network & 5-Band Progression*: - Lightning Sentry: 5-band scaling (base max 314) and +720% synergy (Shock Web, CBS, DS) scaling up to 2574 max damage. - Death Sentry: Corpse explosion radius (10 + slvl - 1 subtiles), shot count scaling with Fire Blast hard points, 40-80% corpse HP explosion. - Blade weapon scaling: Blade Sentinel (3/8), Blade Fury (3/4). 2. *Scenario 2: Martial Arts Charge-Up & Finisher Discharge Pipeline*: - Multi-skill charge accumulation (Tiger + Cobra + Phoenix). - Full finisher discharge on contact releasing all active charges. - Phoenix Strike single-tier payload selection (Meteor, Chain Lightning, Chaos Ice). - Dragon Talon multi-kicks (1 + floor(slvl/6)) and Dragon Claw dual-claw strike mechanics. 3. *Scenario 3: Shadow Disciplines Buff Mechanics & Venom Bitrate Clamp*: - Strict mutual exclusivity between Burst of Speed and Fade. - Venom 10-frame duration clamp and bitrate summing with weapon poison. - Cloak of Shadows recast lockout and defense debuff/buff. 4. *Scenario 4: Minion & Summon Caps*: - Global 5-trap FIFO eviction cap on `assassintrap` PetType. - PetType `shadowwarrior` cap = 1 with mutual replacement between Warrior and Master. - Full coexistence: 5 Traps + 1 Shadow Master = 6 concurrent pets. 5. *Scenario 5: NextDelay Collision Avoidance Across Trees*: - NextDelay hit protection (Wake of Fire 4f, Shock Web 25f, Dragon Flight 4f). 6. *Scenario 6: Cross-Tree Hybrid Build Integration*: - Trapper / Kicksin / Shadow Master combined combat loop without state corruption. 7. *Scenario 7: Crowd Control & Status Effects*: - Mind Blast 4-yard AOE stun & conversion chance with boss/unique immunity. - Psychic Hammer 50/50 magic/phys damage and knockback scaling. 8. *Scenario 8: Complete 30-Skill Registry & Architectural Invariants*: - All 30 skills (IDs 251..280) exist in `D2DataRegistry` with `charClass: "ass"`. - `BATCH1_SKILLS` length invariant strictly maintained at 38. #### Overall Test Results: - All 34 Assassin test files passed: **166/166 tests passed** - TypeScript Typecheck (`tsc --noEmit`): **0 errors** - Merged to `main` via commit `a70ab93` and pushed to `origin/main`.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: troytt/diablo2-web#476
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?